•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-225-1 16 Oct 2024

Done.

DIALIN-DEN-14316-1 19 Dec 2022

Maybe we should just refer to the DG op modes enum in dg_defs.py? Otherwise this is likely to get out of sync w/ enum.

DG-DEN-15367-1 13 Jun 2023

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

DG-DEN-14307-1 19 Dec 2022

Update function header.

DG-DEN-15367-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DD-LEAH-225-1 16 Oct 2024

Done.

HD-DEN-14344-5 05 Dec 2022

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

HD-DEN-14344-5 02 Dec 2022

Remove blank line.

HD-DEN-15367-1 13 Jun 2023

Done

DD-LEAH-225-1 16 Oct 2024

Keep blank line between declaration and code.

HD-DEN-14344-5 05 Dec 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15367-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-14001-1 08 Dec 2022

Done.

DIALIN-DEN-14001-1 08 Dec 2022

Done

UI-DEN-15279-1 14 Jun 2023

RESOLVED

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-17093-1 21 Oct 2024

Done

HD-DEN-14458-1 14 Dec 2022

Done.

HD-DEN-15367-1 14 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 14 Dec 2022

Done.

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

Removed and updated

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15367-1 14 Jun 2023

Implicit bool to BOOL conversion. Prefer explicit conversion with ternary.

HD-DEN-17093-1 21 Oct 2024

This comment is temporary. Update the comment.

HD-DEN-15367-1 14 Jun 2023

Where is currentDGCleaningMode initialized?

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

done.

DIALIN-DEN-15196-7 14 Jun 2023

Why does this situation require sending the status event here (instead of in op modes where this is usually done)?

HD-DEN-17093-1 22 Oct 2024

This code has been removed, please check the handler functions. Also, ternary is a one-liner so sometimes it reduces the lines of code.

LEAHI-DIALIN-LDT-3344-1 12 Feb 2026

Updated

HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15436-1 14 Jun 2023

The next state - which should now be the first drain state - also checks DG modes. I don't see an issue with removing this state except that next state needs to check for DG in fault mode so that it will skip past drain state.

LEAHI-DD-FIRMWARE-LDT-3344-1 11 Feb 2026

In °C?

HD-DEN-15330-1 15 Jun 2023

With this being a WIP im unsure at the moment if both conditions need to do the same thing.

HD-DEN-17093-1 28 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 15 Jun 2023

RESOLVED in CODE WALKTHROUGH.

TD-LEAH-51-1 28 Oct 2024

payload length check to be considered.

HD-DEN-15436-1 15 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15647-1 21 Jun 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15330-1 15 Jun 2023

Align the TRUEs.

DG-DEN-15571-4 15 Jun 2023

Several variables missing from header.

TD-LEAH-51-1 25 Oct 2024

Please align the comments to fit in same column, comparing the top comments.

TD-LEAH-51-1 29 Oct 2024

Fixed.

HD-DEN-15656-1 21 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15647-1 21 Jun 2023

Add hasFlushStatusBeenWrittenToNV to header

DG-DEN-15647-1 21 Jun 2023

Add hasFlushStatusBeenWrittenToNV to header

DG-DEN-15683-1 21 Jun 2023

Declarations should be at top of scope.

DG-DEN-15683-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15683-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15272-1 22 Jun 2023

Moved to function header.