•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

added another error for disconnect

TD-LEAH-51-1 25 Oct 2024

Valve ( V caps)?

UI-DEN-17098-1 28 Oct 2024

please take a look at dry-demo, as well.

HD-DEN-17093-1 31 Oct 2024

Done

HD-DEN-17093-1 31 Oct 2024

I thought drift timeout (30 min) was overrideable. Looks like it's hard coded #define here.

HD-DEN-17093-1 31 Oct 2024

This requests the blood zeroing and then the zeroing state machine does the flush prior to zeroing.

RO-LEAH-244-1 04 Nov 2024

Done

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

dd_defs.

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

Leahi will have no accelerometers.

TD-LEAH-51-1 01 Nov 2024

There is another macro " MAX_SETTABLE_BLOOD_FLOW_RATE" defining 700.. are they similar or different one? may need to change macro name or add comment for clarification.

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 30 Oct 2024

General question - should we (later) make this unit common to all f/w stacks?

RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

updated

DD-LEAH-236-1 11 Nov 2024

Yes, Switches per minute. Just provided incase somebody need to override the switching rate for testing purpose.

DD-LEAH-236-1 08 Nov 2024

The "is" fields should be BOOL I think.

DD-LEAH-236-1 14 Nov 2024

Done.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

this has been removed

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Thank you Nicholas Ramirez, RESOLVED

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Even better naming, thanks.
RESOLVED.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Align color value with others.

LEAHI-APPLICATION-LDT-1536-1 11 Aug 2025

Please use IconButton and a simple implementation.
This implementation is complicated and not flexible.

LEAHI-APPLICATION-LDT-1788-1 12 Aug 2025

I agree, let's keep it, since the text is centered too.
RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

acknowledged

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

acknowledged

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

updated to just show nothing if the image is not needed or does not exist

LEAHI-APPLICATION-LDT-1788-1 12 Aug 2025

http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-1788-1CFR-69529

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED.

DD-LDT-1873-1 13 Aug 2025

Done.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

updated this method to use lOut

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED.

RO-LDT-1809-3 13 Aug 2025

Resolved.

LEAHI-APPLICATION-LDT-1596-1 13 Aug 2025

RESOLVED.

HD-DEN-15278-1 12 Jun 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-17093-1 16 Oct 2024

Done

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14252-1 02 Dec 2022

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

HD-DEN-14344-5 02 Dec 2022

Fixed. Thanks!

DD-LEAH-225-1 16 Oct 2024

done.

DIALIN-DEN-14001-1 08 Dec 2022

What is this doing here? Should be above sync functions below with list of published vars.

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

Done.

HD-DEN-14307-1 19 Dec 2022

Remove comment?

HD-DEN-14307-1 19 Dec 2022

Looks like setServiceTime always returns FALSE.

DIALIN-DEN-14001-1 08 Dec 2022

Looking at unpack functionality a little more, I believe HH will parse a 32-bit byte array as 2 unsigned shorts. I think it's kind of working because byte array is little endian and we're only looking at the first value (index 0) parsed.
Firmware is sending everything as U32. So we should be using "I" for unsigned int.

DD-LEAH-225-1 16 Oct 2024

Done.

DIALIN-DEN-14001-1 08 Dec 2022

May not be needed, but can we just add 0xB8 too for completeness?

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

Done.