Comment Search

Defect Metrics

Statistics on the results
No defects in results

Search Criteria

Search for comments

Search Criteria

Project
Comment content
Review PermaId
After
Before
Comment Author
Search Type
Search Type:
Review State
Review State:
Metrics:
Metric Ranking
Metric Classification
Submit
  •  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-15367-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH
HD-DEN-15367-1 06 Jun 2023

Add disinfectCancelReqID
HD-DEN-14458-1 14 Dec 2022

Should be absolute value (in case measMotorSpeedInRotorRPM is negative for reverse direction).
HD-DEN-14458-1 08 Dec 2022

Remove comments.
DG-DEN-15367-1 13 Jun 2023

Still has a payload. Should remove it.
DG-DEN-15367-1 13 Jun 2023

RESOLVED in CODE WALKTHROUGH.
DG-DEN-15367-1 13 Jun 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-15558-1 13 Jun 2023

Replacing the calculation with a #define and the numeric value for BP flow rate might be helpful.
HD-DEN-15367-1 13 Jun 2023

Done
UI-DEN-15279-1 05 Jun 2023

untill -> until
HD-DEN-15367-1 14 Jun 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-14007-1 15 Dec 2022

Use float literals.
HD-DEN-14007-1 15 Dec 2022

functions/vars should be named a little more descriptively. Instead of drain DG, something like de-prime DG dialysate line.
DG-DEN-14316-1 19 Dec 2022

DG does not send this message. Should be something like MSG_ID_HD_START_STOP_DG_CHEM_DISINFECT_FLUSH_REQUEST.
DG-DEN-14307-1 19 Dec 2022

Alignment
CS-BUILD-0-2-4-1 12 Dec 2022

Why do we need the device's IP address?
where is it being used and what happens if it changes?
DIALIN-DEN-15367-1 14 Jun 2023

Done
DIALIN-DEN-15367-1 14 Jun 2023

RESOLVED
DIALIN-DEN-15367-1 14 Jun 2023

The publish does not seem to be updated with the new fields added. Is that the intention?
DIALIN-DEN-15196-7 14 Jun 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-15330-1 15 Jun 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-15436-1 14 Jun 2023

State removed.
UI-DEN-15279-1 14 Jun 2023

I created a case for this,
please resolve and we will follow up under the case is being displayed above ( DEN-15646 ).
HD-DEN-15436-1 15 Jun 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-15330-1 15 Jun 2023

Fixed. Thanks!
HD-DEN-15330-1 15 Jun 2023

Fixed. Thanks!
HD-DEN-15330-1 14 Jun 2023

Add blank line after function scope.
HD-DEN-15330-1 14 Jun 2023

Add space between if and (.
DG-DEN-15571-4 15 Jun 2023

RESOLVED IN CODE WALKTHROUGH
HD-DEN-15330-1 14 Jun 2023

Please remove the extra blank line.
HD-DEN-15330-1 16 Jun 2023

RESOLVED in CODE WLAKTHROUGH
HD-DEN-15330-1 14 Jun 2023

Why is this a separate condition when it's doing the exact same thing as above?
UI-DEN-15279-1 20 Jun 2023

Please add function headers as needed
UI-DEN-15279-1 20 Jun 2023

Function name here does not match the actual function
UI-DEN-15279-1 20 Jun 2023

"reenalbe" -> "reenable"
HD-DEN-15656-1 21 Jun 2023

Done.
HD-DEN-15656-1 19 Jun 2023

Update header. additionalRinsebackRequired, rinsebackTimerCtr, rinsebackTargetVolume_mL, rinsebackRate_mL_min, endTreatmentRequested.
DG-DEN-15683-1 21 Jun 2023

Done
DG-DEN-15647-1 21 Jun 2023

Done
DG-DEN-15647-1 21 Jun 2023

RESOLVED IN CODE WALKTHROUGH
UI-DEN-15287-9 21 Jun 2023

[~vduong],
This CR is done and the branch is merged into staging.
Please close the branch at your earliest convenience.
DG-DEN-15683-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.
DG-DEN-15683-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-15272-1 22 Jun 2023

Why is the L lower case?
UI-DEN-15279-1 20 Jun 2023

Doxygen comment incorrect for below function
DD-LEAH-225-1 16 Oct 2024

done.
UI-DEN-14294-1 19 Dec 2022

Why commented out?
HD-DEN-14344-5 02 Dec 2022

originally wanted to change setDialInPumpTargetFlowRate() to have the same conditions as testSetDialInPWM but we can integrate it later pending Darren's results.
HD-DEN-14007-1 15 Dec 2022

Use the hard stop function to stop the pump.
DG-DEN-15367-1 13 Jun 2023

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.