•  

Comment Results

Review Name Created Custom Fields Content
DD-LEAH-225-1 16 Oct 2024

isHeaterOn is a strange name for a request. I suspect this field is being used as a state and a request which is a little confusing.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

CS-BUILD-0-2-4-1 15 Dec 2022

Please remove/empty any parameter value which depends on the device, server or something like that.
and keep this file as an empty template.
Same for serials, and names, ...

HD-DEN-17093-1 21 Oct 2024

So then don't you think we should stop all the pumps, wait for pumps to stop and then stabilize and go to bypass?

CS-BUILD-0-2-4-1 14 Dec 2022

Magic numbers.

CS-BUILD-0-2-4-1 14 Dec 2022

Magic number.

CS-BUILD-0-2-4-1 14 Dec 2022

Magic numbers.

HD-DEN-17093-1 21 Oct 2024

Please check the complete handler.

HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 22 Oct 2024

Do we need a else if timeout check here? Can we get stuck waiting for response indefinitely?

HD-DEN-17093-1 28 Oct 2024

Decision is to keep the range. RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 22 Oct 2024

This call to signal pressure stabilization should probably be moved into the request zero function.

TD-LEAH-51-1 28 Oct 2024

looks the same function name used in FpgaTD and BloodFlow.C files. Do we want to differentiate between these two-function naming?

HD-DEN-17093-1 01 Nov 2024

RESOLVED in CODE WALKTHROUGH.

UI-DEN-17098-1 28 Oct 2024

Please refer to: DRY-DEMO-DEN-17098-1

HD-DEN-17093-1 31 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 31 Oct 2024

Relocated the event.

HD-DEN-17093-1 31 Oct 2024

This looks like it would reset the flag way too soon. Shouldn't flag reset be done in the resetBloodLeakZeroing() function?

RO-LEAH-244-1 02 Nov 2024

Done

RO-LEAH-244-1 05 Nov 2024

Removed them.

RO-LEAH-244-1 30 Oct 2024

Remove extra blank line.

DIALIN-DEN-17093-1 01 Nov 2024

You have 2 new variables added to publish but I only see one new variable being set in function.

RO-LEAH-244-1 05 Nov 2024

I haven't done op mode override handler in TD yet so I don't think that is true.

DD-LEAH-236-1 08 Nov 2024

Do we need to include whether or not dialyzer is bypassed? I think TD needs to know if you're bypassing due to invalid temp/cond/pres.
Is 1 second broadcast interval fast enough?

DD-LEAH-236-1 08 Nov 2024

Can we handle start/stop in a single Dialin message?

DD-LEAH-236-1 08 Nov 2024

It looks like this check is only done at beginning of dialysate delivery and, once everything looks ok, we end bypass and never check again.
I think we need to always be checking temp, conductivity, and pressure and bypass whenever anything is off.

UI-DEN-15287-10 13 Nov 2024

The branch is not going to be merged.
But the code needs to be kept.

UI-DEN-14937-6 13 Nov 2024

The branch is not going to be merged.
But the code needs to be kept.

DD-LEAH-236-1 13 Nov 2024

Should this be "if ( DD_MODE_GEND == ddMode )" ? I don't think this message makes sense in any other mode.

DD-LEAH-236-1 14 Nov 2024

Fix "Dialysatey" (remove y). And I think "Gend" should be GenD" in all of these function names.

DD-LEAH-236-1 13 Nov 2024

Seems like this would be a separate state or maybe we go to pause state too.

LEAHI-DIALIN-LEAH-142-2 18 Nov 2024

Fixed. Thanks!

HD-DEN-14344-5 02 Dec 2022

Fixed. moved to testSetDialInPumpWithPWM(). Thanks!

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14253-1 02 Dec 2022

Done.

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 15 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-225-1 16 Oct 2024

done.

HD-DEN-15436-1 14 Jun 2023

Not required. checkPostTreatmentPatientDisconnect() releases the door closed requirements when user confirms patient disconnect. Removed.

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH, no change

HD-DEN-15330-1 15 Jun 2023

Fixed. Thanks!

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED.

DIALIN-DEN-14001-1 08 Dec 2022

Does this work? struct.unpack does not have an HH option.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED.

DD-LEAH-225-1 16 Oct 2024

Do we really need a minimum?

DD-LEAH-225-1 16 Oct 2024

Are both pumps going to have the same coefficients? How did you come up with 1.0 for P and I?

DG-DEN-15367-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH