•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-17098-1 28 Oct 2024

Done

DIALIN-DEN-17093-1 16 Oct 2024

how do we get out of this loop ?

HD-DEN-17093-1 31 Oct 2024

Removed the new varaible.

HD-DEN-17093-1 31 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 01 Nov 2024

Done

RO-LEAH-244-1 02 Nov 2024

In TD it is in the same file.

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

Align to Leahi message list.

RO-LEAH-244-1 30 Oct 2024

Same. This is DD code. Leave this alone.

RO-LEAH-244-1 04 Nov 2024

This looks to be TD specific one.

RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.

RO-LEAH-244-1 04 Nov 2024

The fault should be false as it is not related to HD issue.

DD-LEAH-236-1 11 Nov 2024

Will handle in next revision. created a placeholder.

DD-LEAH-236-1 11 Nov 2024

Done.

DD-LEAH-236-1 08 Nov 2024

How would Dialin user request to stop the pump?

DD-LEAH-236-1 08 Nov 2024

Do we need to initialize standby and dialysate delivery modes?

DD-LEAH-236-1 08 Nov 2024

Should have other variables from dialysate delivery command msg from TD. i.e. UF rate, target dialysate temp, dialyzer bypass, and concentrate types.

DD-LEAH-236-1 13 Nov 2024

This message handler would be more appropriately placed in TDInterface unit.

DD-LEAH-236-1 14 Nov 2024

If no inputs or outpus, say "none".

LEAHI-DIALIN-LEAH-142-2 18 Nov 2024

Fixed. Thanks!

RO-LEAH-250-1 19 Nov 2024

Fixed.

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Could you please check the order of bytes against the concentrate pump data structure declaration? I see the 3rd parameter in structure is CP2 current set speed.

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

There is one more test routine added later in the source code (MSG_ID_DD_CONCENTRATE_PUMPS_START_STOP_OVERRIDE_REQUEST). Please add the dialin support.

LEAHI-DIALIN-LEAH-142-2 12 Nov 2024

HD s/b TD. States not really defined yet - ok to leave as is for now.

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

float type for both primary and trimmer duty cycle.

LEAHI-DIALIN-LEAH-142-2 12 Nov 2024

Update to match current broadcast payload.

HD-DEN-15367-1 12 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 02 Dec 2022

FIXED IN CODE WALKTHROUGH

HD-DEN-14344-5 02 Dec 2022

remove "," after pwm.

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1 12 Jun 2023

Should this be a s/w fault?

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH, no change

HD-DEN-17093-1 16 Oct 2024

Done

HD-DEN-17093-1 16 Oct 2024

You need to cast numerator and denominator as F32 or it doesn't really help.

HD-DEN-14252-1 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 05 Dec 2022

Removed.

DIALIN-DEN-14001-1 08 Dec 2022

Done.

DIALIN-DEN-14001-1 08 Dec 2022

Should this be in the class?

DD-LEAH-225-1 16 Oct 2024

handled in the 'setDialysatePumpTargetRPM' function.

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

This is another if/else. When doing this, we are saying there will only ever be 2 heaters. Where we use a switch statement, we are making it possible to add more heaters later. We should at least be consistent about how we do this throughout the unit.

HD-DEN-14458-1 14 Dec 2022

Done.

DD-LEAH-225-1 16 Oct 2024

Why use a switch statement in some cases and an if/else here?

HD-DEN-14458-1 14 Dec 2022

Done.

DD-LEAH-225-1 16 Oct 2024

I don't see init called in sys_main and I don't see exec called in priority task.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 08 Dec 2022

Remove comment and bracket

HD-DEN-14099-1 19 Dec 2022

Code is removed. RESOLVED in CODE WALKTHROUGH.