Comment Search

Need to add this call to initialize common FPGA driver:
initFPGA( (U08*)&fpgaHeader, (U08*)&fpgaSensorReadings, (U08*)&fpgaActuatorSetPoints,
sizeof(FPGA_HEADER_T), sizeof(FPGA_SENSORS_T), sizeof(FPGA_ACTUATORS_T) );

This is too brief. Assume we want at least 3 samples to show below threshold. That's 12 seconds.

As we talked, please use check blocks instead of the nested multi-level if/else.
Also, if you want to reuse the same variable, name it more generally, like info, instead of IP.

QString info  = tr("WiFi Connection Error");
if ( ! _wifiValid ) { goto lOut; }

info  = tr("No WiFi");
if ( ! dev.isValid ) { goto lOut; }

info = tr("WiFi Not Connected");
if ( ! addresses.count() ) { goto lOut; }

if ( ! ( dev.flags().testFlag(QNetworkInterface::IsUp) && dev.flags().testFlag(QNetworkInterface::IsRunning) ) )  { goto lOut; }

info = addresses.first().ip().toString();

lOut:
 emit didWifiData(info);

add the doInitWifiInfo and remove thsi to be the returned result of the call.

make the wlan0 a const private value of the class.

I believe this does need to be a pointer exposing it to QML because it is derived from QAbstractListModel we should expose a pointer to the actual model. Ff we pass it by value it will get some kind of deep copy of the model not the actual model. So the QML listview will not update when the _instructionsList changes

RESOLVED.

remove me

Have you tested the race condition here?
Is the _repeater initialized before the property being initialized?
How do you make sure we do not have a race condition?

updated

Or maybe 110 was correct and fault property should be FALSE and DD fault property should be TRUE? This doesn't look like a TD fault. All other faults are DD faults.

updated

For both sensors, the .data should only be set once to final value. Use a temporary local variable until it's ready.

First part of condition should have () around it too.
Do we want to set direction here even if we fail to satisfy condition below?

"bloodLeakPersitentCounter" should be bloodLeakPersistentCounter

Must have worked. I think just one H is all that's needed for unsigned short. Not sure why type "int" is being parsed as unsigned short though.

Comment alignment.

RESOLVED in CODE WALKTHROUGH.

I know I told you to do shift division, but I want a float for average so we need to do real division by sample count.

RESOLVED in CODE WALKTHROUGH.

Why not just call stopHeater() here? And why are we checking for request at bottom of exec - shouldn't we do this first?

Updated.

Update function header.

Fixed.

This is in the dg_tests.py which is used for running various tests. This is not part of dialin modules. In this case exiting the loop is done manually by stopping the script.