•  

Comment Results

Review Name Created Custom Fields Content
TD-LEAH-51-1 04 Nov 2024

Per comment, 1320 is maximum "measured" flow rate. 700 is maximum "settable" flow rate. 500 is maximum prescribed flow rate.

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 30 Oct 2024

RO, not HD.

RO-LEAH-244-1 06 Nov 2024

Fixed.

RO-LEAH-244-1 06 Nov 2024

Will add in next branch.

RO-LEAH-244-1 30 Oct 2024

Ordering looks wrong here. Should be in order of priority/channel #.

UI-DEN-17098-1 28 Oct 2024

fix the numbering (should be 4).

DD-LEAH-236-1 13 Nov 2024

Removed balancing chamber pause state.

DD-LEAH-236-1 14 Nov 2024

Done.

DD-LEAH-236-1 14 Nov 2024

Done.

DD-LEAH-236-1 14 Nov 2024

If no alarms triggered, don't include an Alarm details line in the header.

DD-LEAH-236-1 14 Nov 2024

Who is calling this function? If this function is not doing anything other than changing modes, do we really need this function? Caller can just call requestNewOperationMode().

RO-LDT-566-1 24 Jun 2025

That'll be in the next branch. Trying to keep the changes controlled for now

HD-DEN-15278-1 12 Jun 2023

Done.

HD-DEN-14344-5 02 Dec 2022

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

HD-DEN-15367-1 12 Jun 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-14001-1 08 Dec 2022

That is right. Done.

DIALIN-DEN-14001-1 08 Dec 2022

Done.

RO-LEAH-244-1 05 Nov 2024

Removed them.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED.

HD-DEN-14458-1 14 Dec 2022

Done.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 16 Oct 2024

Done

HD-DEN-14099-1 19 Dec 2022

Cleaned up missed artifacts from moving the bubble pressure code.

DG-DEN-15367-1 12 Jun 2023

Not really "off". Should be applied when going slowly (<10 mL/min).

HD-DEN-17093-1 16 Oct 2024

Average should be float.

DG-DEN-14316-1 19 Dec 2022

Remove blank line.

DG-DEN-14316-1 30 Nov 2022

Alignment

HD-DEN-17093-1 16 Oct 2024

Average should be a float. Allows much more precision. Reduces noise which is primary reason why we are doing a moving average.

HD-DEN-17093-1 16 Oct 2024

I think we should do this on exit from self-test state on its way to normal.

DG-DEN-14316-1 19 Dec 2022

Don't need two of these. Remove one.

HD-DEN-14307-1 19 Dec 2022

Update function header.

CS-BUILD-0-2-4-1 12 Dec 2022

Update all the function docstrings?

DD-LEAH-225-1 16 Oct 2024

done.

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

Looks like this TODO is done.

TD-LEAH-51-1 28 Oct 2024

unit variables initialized.

HD-DEN-17093-1 21 Oct 2024

Done.

UI-DEN-17098-1 08 Nov 2024

RESOLVED

HD-DEN-17093-1 21 Oct 2024

This exec is also used by treatment stop at the moment. I have to make some changes then.

HD-DEN-17093-1 21 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 21 Oct 2024

I didn't see a new state added to enum in HDDefs.h. Do we want to add a new state? I thought we were going to model this after saline bolus which is a sub-state of existing dialysis state.

HD-DEN-17093-1 21 Oct 2024

I'm not seeing fix.

DG-DENBUG-276-1 22 Oct 2024

I think so. This is to catch all the time that the concentrate pumps are running. If the concentrate pumps are not running, then nothing is accumulated.

TD-LEAH-51-1 28 Oct 2024

Fixed.

RO-LEAH-244-1 30 Oct 2024

I disagree with this change. MODE_INIT is a TD mode.

RO-LEAH-244-1 02 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

Done