•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Please add the support for "MSG_ID_DD_DIALYSATE_PUMPS_START_STOP_OVERRIDE_REQUEST".

LEAHI-DIALIN-LEAH-142-2 12 Nov 2024

For this class (I would just name the class pressure instead of pressure_sensors) you need to look at the PressureSensors driver and the Pressures monitor f/w units. The monitor unit has an override for broadcast interval.
FYI - this type of thing will be common in Leahi where we split f/w into two units: 1) low level driver and 2) higher level controller or monitor. So keep any eye out for this when matching functionality to what f/w is supporting.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

The height was hard coded to a fixed number and since the header bar sits on top of this the top portion of all the settings pages were hidden behind

RO-LEAH-262-1 25 Nov 2024

Do you want to update these alarms later? The commented code still referencing DD alarms.

RO-LEAH-262-1 25 Nov 2024

Please align the comments.

HD-DEN-15367-1 06 Jun 2023

Add function header.

HD-DEN-15367-1 09 Jun 2023

Blank line between declarations and code.

HD-DEN-14458-1 12 Dec 2022

Remove blank line.

HD-DEN-14458-1 08 Dec 2022

Update function header.

HD-DEN-17093-1 22 Oct 2024

So now it's enough if 1 or 2 samples in the drift range is enough to re-zero? Still seems too brief to me.

DG-DEN-15367-1 12 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14007-1 19 Dec 2022

Updated.

DG-DEN-14316-1 30 Nov 2022

Remove

DG-DEN-14307-1 19 Dec 2022

Update function header.

UI-DEN-14294-1 19 Dec 2022

The body of this function looks all commented out. Is this function necessary?

HD-DEN-17093-1 16 Oct 2024

Done

CS-BUILD-0-2-4-1 14 Dec 2022

Magic number.

HD-DEN-14344-5 02 Dec 2022

parameter0?

HD-DEN-14344-5 02 Dec 2022

Where did this enum name change take place? There is no common in this code review.

HD-DEN-17093-1 16 Oct 2024

This is a minimum interval, not "the" interval.

HD-DEN-14252-1 02 Dec 2022

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

DD-LEAH-225-1 16 Oct 2024

done.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED.

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

Done.

HD-DEN-14458-1 14 Dec 2022

Done.

DIALIN-DEN-17093-1 16 Oct 2024

Average should be a float.

DD-LEAH-225-1 16 Oct 2024

Comment does not make clear what this is doing. Do we need it?

TD-LEAH-51-1 28 Oct 2024

Fixed.

TD-LEAH-51-1 28 Oct 2024

Fixed.

DD-LEAH-236-1 11 Nov 2024

Done.

HD-DEN-17093-1 22 Oct 2024

Not clear to me that this is any better than bypassing the dialyzer in previous state and is likely worse. The way you have it now, the dialysate being pushed by DPi is going to run into a stopped DPo and cause a big pressure spike and push dialysate into blood side.

HD-DEN-17093-1 21 Oct 2024

...stop the pump(s) before going ...

UI-DEN-17098-1 28 Oct 2024

RESOLVED

RO-LEAH-244-1 04 Nov 2024

FpgaRO. change all TD references to RO.

HD-DEN-17093-1 30 Oct 2024

Per the Systems team the debounce time was set to 10 seconds.

HD-DEN-17093-1 31 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 31 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 01 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

Done

RO-LEAH-244-1 02 Nov 2024

These are auto-generated that is why I left them. They are now changed.

RO-LEAH-244-1 02 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

Removed it.

RO-LEAH-244-1 04 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

TD ->RO

DD-LEAH-236-1 11 Nov 2024

was already taken care., There are two flags being published ( isDialysateGoodtoDeliver , isDialDelInProgress ).

UI-DEN-14743-1 13 Nov 2024

The branch is not going to be merged.
But the code needs to be kept.

RO-LEAH-244-1 06 Nov 2024

Removed.