Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 typed variable so it will be typed properly. A #define may or may not be typed depending on how it's used. If it's used in a mathematical expression, the compiler will make it max precision (double) if we don't explicitly add the 'F' suffix and that can cause some problems with the precision in the math.
I know all the FW code is written in this style but it is always interesting to me, 1 - why don't just say
if ( isSyringePumpPreLoaded() )
the function is a boolean why compare to TRUE to get a bool expression? if it was returning an int it made sense to have something like this:
if ( isSyringePumpPreLoaded() != 0 )
Which is still unnecessary in some cases. 2 - even if we want to use TRUE, why to put it at the beginning of the expression and don't put it at the end, like
if ( isSyringePumpPreLoaded() == TRUE )
So the first thing developer sees would be the important part which is the function not always a TRUE or FALSE.
