•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14001-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 14 Oct 2022

Can we uncomment this now?

HD-DEN-13834-1 14 Oct 2022

0.0F (pwm) param not in function - remove.

HD-DEN-14175-1 09 Nov 2022

Done.

HD-DEN-14150-1 18 Oct 2022

Instead of 0 maybe a constant

HD-DEN-14150-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14170-1 04 Nov 2022

Ok to calculate here (this is called before UI needs it I assume). I was expecting this to be pre-calculated on exit of treatment params mode or on entry to pre-treatment mode when we have what we need to do the calculation.

HD-DEN-14170-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-13962-1 07 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14150-1 08 Nov 2022

Remove extra blank line. Should only be 1 blank line between functions.

HD-DEN-14170-1 08 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 09 Nov 2022

Doesn't this command take a pointer to a structure now?

DIALIN-DEN-14175-1 08 Nov 2022

Could you please explain what is this file and how is going to be used?

DIALIN-DEN-14175-1 08 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 09 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 09 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14175-1 10 Nov 2022

Done.

DG-DEN-14175-1 09 Nov 2022

Restore or remove.

DG-DEN-14175-1 10 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14175-1 09 Nov 2022

Isn't fpgaSensorReadings an input?

DIALIN-DEN-14175-1 10 Nov 2022

Done.

DIALIN-DEN-14175-1 10 Nov 2022

RESOLVED.

DG-DEN-14197-1 21 Nov 2022

Remove blank lines

HD-DEN-14150-1 11 Nov 2022

Done

HD-DEN-14150-1 11 Nov 2022

Need to make sure these only get called once before pre-treatment.

DG-DEN-14197-1 21 Nov 2022

Update header.

DG-DEN-14316-1 21 Nov 2022

Doxygen descriptions.

DG-DEN-14197-1 21 Nov 2022

Variable suggests this is a duty cycle (not a voltage). Suggest renaming function.

DG-DEN-14197-1 21 Nov 2022

Update header. Looks like header may have been incorrect before changes.

HD-DEN-14099-1 18 Nov 2022

If this condition (timeout) occurs in middle of pressure build up, will we release on transition to next state?

DG-DEN-14316-1 21 Nov 2022

Indent

DG-DEN-14316-1 21 Nov 2022

Indent

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14197-1 21 Nov 2022

Update header.

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14197-1 21 Nov 2022

Remove extra blank line.

DG-DEN-14197-1 21 Nov 2022

Add another blank line here (separates normal code from test code).

DG-DEN-14197-1 21 Nov 2022

Remove extra blank line.

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14197-1 21 Nov 2022

Put parenthesis around inner conditions. Put constant on left side of "==".

DG-DEN-14197-1 21 Nov 2022

Should be using variable names? or is description OK?

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14316-1 21 Nov 2022

General comment on alignment.

DG-DEN-13460-2 20 Sep 2022

Restore this blank line.

UI-DEN-13198-1 19 Sep 2022

During installation last week was having issues where this check seems to be looking for $CLOUDSYNC_FOLDER in root directory, whereas instructions say to install cloudsync folder in home directory, if I'm understanding correctly the condition should be $HOME$CLOUDSYNC_FOLDER

HD-DEN-13712-1 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH