RESOLVED in CODE WALKTHROUGH
Already uncommented.
RESOLVED IN CODE WALKTHROUGH
RESOLVED in CODE WALKTHROUGH.
Can we uncomment this now?
0.0F (pwm) param not in function - remove.
Done.
Instead of 0 maybe a constant
Ok to calculate here (this is called before UI needs it I assume). I was expecting this to be pre-calculated on exit of treatment params mode or on entry to pre-treatment mode when we have what we need to do the calculation.
Remove extra blank line. Should only be 1 blank line between functions.
Doesn't this command take a pointer to a structure now?
Could you please explain what is this file and how is going to be used?
Restore or remove.
Isn't fpgaSensorReadings an input?
RESOLVED.
Remove blank lines
Done
Need to make sure these only get called once before pre-treatment.
Update header.
Doxygen descriptions.
Variable suggests this is a duty cycle (not a voltage). Suggest renaming function.
Update header. Looks like header may have been incorrect before changes.
If this condition (timeout) occurs in middle of pressure build up, will we release on transition to next state?
Indent
Alignment
Remove extra blank line.
Add another blank line here (separates normal code from test code).
Put parenthesis around inner conditions. Put constant on left side of "==".
Should be using variable names? or is description OK?
General comment on alignment.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
