•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13801-1 21 Oct 2022

Remove extra blank line.

HD-DEN-13801-1 21 Oct 2022

Remove blank line.

HD-DEN-13801-1 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14166-1 21 Oct 2022

Move up to line ~108 where the other shift #defines are.

DG-DEN-14237-1 03 Nov 2022

Remove references to this flag.

HD-DEN-13801-1 28 Oct 2022

Needs doxygen comment.

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Remove extra blank line.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Comment doesn't match time.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 27 Oct 2022

Remove TODO comment.

DG-DEN-14237-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14237-1 03 Nov 2022

Remove TRUE case. Just need the else now.

DG-DEN-14237-1 03 Nov 2022

Can we remove this code?

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

HD-DEN-14150-1 04 Nov 2022

Done.

HD-DEN-14150-1 04 Nov 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 12 Sep 2022

Should initialization use 0.0F?

DG-DEN-13427-1 07 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 16 Sep 2022

Remove blank line.

HD-DEN-13427-1 07 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13460-2 16 Sep 2022

Keep blank line.

DG-DEN-13598-2 21 Sep 2022

Remove comment at end of line.

DG-DEN-13598-2 21 Sep 2022

Remove comment at end of line.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 19 Sep 2022

No explanation for commenting this function.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 19 Sep 2022

Merge markers need to be removed.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-13460-1 16 Sep 2022

conversion.py

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13460-2 14 Sep 2022

We can have either of the values set without the other value set.

HD-DEN-13834-1 19 Sep 2022

Should 365 be #define? Why changed from #define to static const U32?

HD-DEN-14001-1 17 Oct 2022

Fixed.

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14150-1 18 Oct 2022

Removed all blank lines.

HD-DEN-14150-1 19 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13801-1 19 Sep 2022

Last value is 0, should be 0.0. Do they need to be 0.0F?

DIALIN-DEN-13460-1 21 Sep 2022

I believe there has been a request in the DIAL project to convert these to conversion.