•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13460-2 20 Sep 2022

Add blank line between declaration and code.

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13460-2 16 Sep 2022

I don't see this function implemented in c file.

HD-DEN-13460-2 01 Sep 2022

Done.

UI-DEN-13198-1 19 Sep 2022

Missing square brackets around equality check

DG-DEN-13598-2 21 Sep 2022

Initialize these in init function below (like other variables).

DG-DEN-13598-2 19 Sep 2022

Already removed the merge markers.

DG-DEN-13598-2 21 Sep 2022

Please restore to normal return value and remove comments.

HD-DEN-13598-2 02 Sep 2022

Need to initialize here at declaration or in init function. I see neither now.

DG-DEN-13598-2 21 Sep 2022

Remove blank line.

DG-DEN-13598-2 21 Sep 2022

Remove this extra blank line.

HD-DEN-13598-2 02 Sep 2022

I think the style is to use set/get functions if needed by other modules, otherwise just access the variable directly.

DG-DEN-13598-2 19 Sep 2022

Merge markers need to be removed.

DG-DEN-13598-2 19 Sep 2022

These merge markers will cause a build failure. Need to be removed.

DG-DEN-13598-2 19 Sep 2022

Merge markers need to be removed.

DIALIN-DEN-13460-1 06 Sep 2022

What's the difference between target speed and set speed in this message?

HD-DEN-13427-1 07 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-13460-1 16 Sep 2022

I thought we talked about using the functions in conversion.py, right?

DIALIN-DEN-12716-1 08 Sep 2022

Ok, let's do that. RESOLVED.

DG-DEN-13834-1 20 Sep 2022

Should 100.0 be a #define?

DG-DEN-13427-1 12 Sep 2022

RESOLVED IN CODE WALKTRHOUGH

HD-DEN-13460-2 30 Aug 2022

Is the "F" required after floating point constant? Should be consistent.

DG-DEN-13598-2 19 Sep 2022

Already removed the merge markers .

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 19 Sep 2022

Already removed merge markers.

DG-DEN-13598-2 19 Sep 2022

Already removed the merge markers.

HD-DEN-13460-2 30 Aug 2022

Should be at left margin?

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

HD-DEN-13801-1 19 Sep 2022

Magic number 1500. Give an explanation or define constant elsewhere.

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 19 Sep 2022

Update header?

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 17 Oct 2022

Done.

HD-DEN-13834-1 14 Oct 2022

Space before end )

HD-DEN-14001-1 17 Oct 2022

Remove extra space after static.

HD-DEN-14001-1 14 Oct 2022

Need one more indent for this IF statement.

DG-DEN-13460-2 21 Sep 2022

I think idea here is that we don't want any process to hold onto semaphore for very long so it can't block other processes for too long. If another process is calling this function to try to access the protected resource, it will check for timeout and alarm if semaphore has been held for too long.

DIALIN-DEN-13460-1 21 Sep 2022

I believe there has been a request in the DIAL project to convert these to conversion.

DIALIN-DEN-13460-1 21 Sep 2022

I believe there has been a request in the DIAL project to convert these to conversion.

DG-DEN-13460-2 21 Sep 2022

The typo has been fixed in DEN-13834.