•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13801-1 21 Oct 2022

Remove extra blank line.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13903-2 12 Oct 2022

Please see comment above.

HD-DEN-13903-1 12 Oct 2022

Add space before last ")"

HD-DEN-13903-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

Why aren't these being filtered like other FPGA voltages in getFpgaADC()?

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 04 Oct 2022

Add 2 blank lines before test support banner.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 04 Oct 2022

Add blank line after declaration.

HD-DEN-14000-1 07 Oct 2022

Should add a comment for this (and maybe a #define). Looks like this value will prevail if measured RPM is zero so would expect infinite persist I guess - though shouldn't be calling this function when pump is stopped I would think. Should probably be 8 Fs (not 7).

HD-DEN-14000-1 07 Oct 2022

Why don't we want to distinguish forward and reverse speeds with sign?

HD-DEN-14001-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14166-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

Moved.

DG-DEN-13786-1 24 Oct 2022

Alphabetize (move toward top of includes).

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Add blank line after declarations.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Add doxygen comment.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 03 Nov 2022

No these should be TRUE.

HD-DEN-14175-1 03 Nov 2022

This function should stay commented. I have a TODO task for this.

DG-DEN-14175-1 03 Nov 2022

No, it should be removed.

HD-DEN-14175-1 03 Nov 2022

Remove blank line

HD-DEN-14175-1 28 Oct 2022

This revision also applies to UI.

DG-DEN-13460-2 29 Aug 2022

Should this function handle invalid hex characters?

HD-DEN-13598-2 31 Aug 2022

Sean Nash Dara Navaei

Does this code review also need the common repo as well? There are changes within this branch that look like they have changes in alarmdefs.h.

TD-LDT-1886-7 23 Oct 2025

Done

HD-DEN-14000-1 10 Oct 2022

Done.

HD-DEN-15367-1 12 Jun 2023

Updated the function header.

HD-DEN-14000-1 10 Oct 2022

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

DG-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-14000-1 10 Oct 2022

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

HD-DEN-14000-1 07 Oct 2022

Should add a break from loop here.

DIALIN-DEN-13903-1 22 Sep 2022

Missing payload.

HD-DEN-13460-2 31 Aug 2022

Done.

DG-DEN-14175-1 03 Nov 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13903-1 12 Oct 2022

Fixed. Thanks!