•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14001-1 18 Oct 2022

Done.

HD-DEN-13598-2 30 Aug 2022

I added a blank line above those new constants.

HD-DEN-13460-2 30 Aug 2022

Remove code.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

valveStatus is both input/output.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Remove TODO.

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13460-2 31 Aug 2022

Done.

DG-DEN-13460-2 31 Aug 2022

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

DG-DEN-13460-2 31 Aug 2022

Done.

DG-DEN-13460-2 31 Aug 2022

This code is un-commented.

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 31 Aug 2022

Remove blank line.

DG-DEN-13427-1 25 Aug 2022

Send functions usually return a BOOL.

HD-DEN-13460-2 30 Aug 2022

Update function header. reservoirState.

HD-DEN-13460-2 30 Aug 2022

Remove commented code.

HD-DEN-13460-2 01 Sep 2022

More of a caution than an explicit fix. Dong's S77 branch has some of the changes that are reflected here. He also has the more recent commit. Be careful when both of you merge your branches.

DG-DEN-13460-2 26 Aug 2022

When will it be uncommented?

HD-DEN-15367-1 12 Jun 2023

Done

HD-DEN-13834-1 04 Oct 2022

What is the significance of (OBSOLETE)? Applies to several blocks.

HD-DEN-14001-1 03 Oct 2022

OK, I see what you wanted. I have a couple of questions:
Is logging of the 3 values (remaining charge, battery status, charger status) in a separate message every 750 ms correct?
If so, could that be done by calling the publishBatteryStatusData function when the 3rd value (charger status) is read?

HD-DEN-12609-2 26 Aug 2022

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

DIALIN-DEN-13903-1 03 Oct 2022

Michael Garthwaite,
please revert back these changes.
it also broke the Simulator.

HD-DEN-12609-2 26 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12609-2 14 Jun 2022

These are redundant with above. Keep above definitions as they have the 'F' suffix that we want. Remove these.

HD-DEN-12609-2 26 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12609-2 26 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12609-2 26 Aug 2022

RESOLVED in CODE WALKTHROUGH

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 07 Oct 2022

Somewhere around line 450 there is a separator between normal and Dialin test support functions. These new functions are normal so should be above that separator. Looks like there's a few more normal functions down here too that should be moved.

DD-LEAH-225-1 16 Oct 2024

Its Forward direction only. added comments.

HD-DEN-13834-1 13 Oct 2022

This looked better before. Why change?

HD-DEN-13598-2 30 Aug 2022

I removed all counters.

HD-DEN-14000-1 07 Oct 2022

Is this reject from HD or user or both? Comment suggests from HD only.

DD-LEAH-225-1 16 Oct 2024

done.

HD-DEN-14000-1 07 Oct 2022

This enum is HD to UI only. Updated comments.

HD-DEN-13460-2 31 Aug 2022

This is still a TODO. We are trying to avoid a switch for the batteries overall.

DG-DEN-13460-2 31 Aug 2022

Added TODO to un-comment this line of code.

DG-DEN-13460-2 31 Aug 2022

In in DEN-13834.

DG-DEN-13460-2 31 Aug 2022

Line 1902 is the same check but reverses the order.

HD-DEN-13460-2 31 Aug 2022

This function header is up to date.

DG-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.