•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-12609-2 25 Aug 2022

Remove all of these new blank lines.

HD-DEN-13460-2 31 Aug 2022

Does this need to be changed on the DG's side as well?

HD-DEN-13598-2 31 Aug 2022

Please remove double include.

HD-DEN-13834-1 29 Sep 2022

It is a const because we want it to be calculated upon compilation and be kept in memory. #define does the calculations every time it is called.

DIALIN-DEN-13903-1 03 Oct 2022

Thanks for the clarification.
RESOLVED.

HD-DEN-13712-1 29 Aug 2022

See previous alarm comment.

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13460-2 31 Aug 2022

True we have to be consistent. Added "F".

HD-DEN-13801-1 28 Oct 2022

Add blank line before return.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13834-1 12 Oct 2022

Removed the "no event" event.

HD-DEN-13834-1 04 Oct 2022

Why not checking payload length?

HD-DEN-13834-1 04 Oct 2022

Why was blank line removed?

HD-DEN-13460-2 01 Sep 2022

Done.

DG-DEN-13460-2 29 Aug 2022

Should this be removed?

HD-DEN-13460-2 30 Aug 2022

Update function header.

DG-DEN-13834-1 12 Oct 2022

For handling of Dialin commands, we do not alarm. We want Dialin support code to be nonintrusive and we will ignore any Dialin command that isn't valid.

HD-DEN-14001-1 18 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

This function is called by the exec that loops through the list of reactors.

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

Removed the #define.

HD-DEN-13903-2 12 Oct 2022

Fixed. Thanks!

HD-DEN-13903-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

1.8V is expected.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14150-1 19 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14101-1 18 Oct 2022

I don't see this used anywhere.

HD-DEN-13801-1 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13903-2 21 Oct 2022

Fixed. Thanks!

HD-DEN-13903-2 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14166-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Remove dead code.

HD-DEN-13801-1 28 Oct 2022

Remove blank line.

DG-DEN-14175-1 03 Nov 2022

This is done to get an average of the fill temperature as well as the last fill temperature prior to tranistioning to Gen Idle. These values are used for the next estimation and are different from the heaters driver.

HD-DEN-14175-1 03 Nov 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14175-1 31 Oct 2022

Remove comment.

DG-DEN-14175-1 03 Nov 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14237-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 03 Nov 2022

Update function header.

DG-DEN-14237-1 03 Nov 2022

Removed. Intended to remove all along.

DG-DEN-14237-1 03 Nov 2022

Removed

DG-DEN-14237-1 03 Nov 2022

Removed

DG-DEN-14237-1 03 Nov 2022

This flag also should be removed.