•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

DG-DEN-13460-2 26 Aug 2022

No comment to explain why it is all commented.

DG-DEN-13834-1 04 Oct 2022

Can we remove "TODO" since implementation is not required at this time. Re-phrase comment to something like "If temp sensors require calibration, implement here."

DG-DEN-13786-1 24 Oct 2022

This is not a software fault. This has been addressed in DEN-14166.

HD-DEN-15367-1 12 Jun 2023

Alignment.

HD-DEN-13834-1 03 Oct 2022

Are all available ALARM_IDs being removed?

DG-DEN-13834-1 28 Sep 2022

Not really an output.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 04 Oct 2022

This looks like 104 (not 106). And we should be noting every 5th enum anyway.

DG-DEN-13834-1 04 Oct 2022

POST does nothing? If always in progress, do we get stuck in this test?

HD-DEN-14000-1 10 Oct 2022

Updated.

DIALIN-DEN-13903-1 12 Oct 2022

Fixed. Thanks!

DIALIN-DEN-13903-1 12 Oct 2022

RESOLVED.

DIALIN-DEN-13903-1 12 Oct 2022

RESOLVED.

DG-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13834-1 12 Oct 2022

I am waiting for HDD to be updated to reserved so I can rename them.

HD-DEN-14000-1 07 Oct 2022

Convention is to put spaces around operators like = and <.

HD-DEN-13834-1 28 Sep 2022

Add trimmerState.

HD-DEN-14001-1 18 Oct 2022

Done.

HD-DEN-14001-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14150-1 19 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14101-1 21 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13786-1 24 Oct 2022

This function has been refactored.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Remove commented out line of code.

HD-DEN-13801-1 28 Oct 2022

Remove commented out line of code.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 27 Oct 2022

Remove

DG-DEN-14237-1 03 Nov 2022

Removed

DG-DEN-14237-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14170-1 04 Nov 2022

Thought we had decided that the standard would be to add the F?

HD-DEN-14170-1 04 Nov 2022

It is reset on Retract / Home completion. Once the Seek occurs, it is no longer valid so I reset it here on Seek completion.SelfTest.c uses this flag in progression from Retract to Preload to Seek to Prime. .

HD-DEN-14170-1 04 Nov 2022

We probably don't need this flag at this point, but should we reset this flag on exit of retract (after treatment done)?

HD-DEN-14170-1 04 Nov 2022

If we want to do that for consistency, that's fine but let's handle that as a bulk update and going forward kind of thing rather than keep commenting individually on code reviews.

HD-DEN-14150-1 21 Oct 2022

SW_CONFIG_ENABLE_VALUE should be first blue in if statement

HD-DEN-14170-1 03 Nov 2022

0.0F

UI-DEN-13962-1 04 Nov 2022

Why is there 2 spaces between . and field name?

HD-DEN-14150-1 07 Nov 2022

Remove test code.

HD-DEN-14170-1 04 Nov 2022

I think the else can end right after ramp. Ok to do checks I would think.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 26 Aug 2022

Remove comment.