•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-12974-1 16 Aug 2022

Corrected.

DG-DEN-12974-1 16 Aug 2022

Corrected.

DG-DEN-12974-1 16 Aug 2022

Corrected.

DG-DEN-12974-1 12 Aug 2022

Required for V&V Testing.

DG-DEN-12974-1 12 Aug 2022

This code will be updated to be consistent with the getRsrvrFillStatus from FLUSH mode.

DG-DEN-12974-1 12 Aug 2022

This code will be updated to be consistent with the getRsrvrFillStatus from FLUSH mode.

DG-DEN-12974-1 12 Aug 2022

This code will be updated to be consistent with the getRsrvrFillStatus from FLUSH mode.

HD-DEN-13141-6 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 17 Aug 2022

Lower minimum to 0 and remove last or condition.

DG-DEN-12974-1 17 Aug 2022

Change minimum to 0 and remove last or condition.

DG-DEN-12974-1 17 Aug 2022

Lower minimum to 0 and remove last or condition.

HD-DEN-13141-6 15 Aug 2022

You mean the blank line?

HD-DEN-13141-6 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 12 Aug 2022

Required for V&V testing.

HD-DEN-12609-2 26 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 29 Aug 2022

Should this be in or not?

DG-DEN-12974-1 19 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 28 Jun 2022

I think we need two separate minimums here.
1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name.
2. used by UVReactors.c should be 0.3 and private (declared in UVReactors.c) with a different name like MIN_RO_FLOW_FOR_UV_LPM.

UI-DEN-15279-1 12 Jun 2023

Thanks,
Fixed.

HD-DEN-12609-2 24 Aug 2022

Can you clarify what case you're thinking of?

UI-DEN-15279-1 12 Jun 2023

Thanks,
Fixed.

HD-DEN-15367-1 12 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12609-2 24 Aug 2022

Extra space before comment.

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13903-1 12 Oct 2022

Remove last param.