•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14170-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 07 Nov 2022

Done.

HD-DEN-14170-1 03 Nov 2022

0.0F

HD-DEN-14150-1 07 Nov 2022

Remove test code.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 21 Nov 2022

Set alarm pending here?

DG-DEN-13834-1 28 Sep 2022

That is 110.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 23 Jul 2022

TODO should be all CAPS.

UI-DEN-15279-1 12 Jun 2023

Thanks,
Fixed.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 28 Sep 2022

Done.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15279-1 12 Jun 2023

Thanks,
Fixed.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 29 Sep 2022

Both cannot be and are not defined at the same time.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

HD-DEN-13801-1 30 Sep 2022

Update function header.

HD-DEN-14001-1 18 Oct 2022

Done.

HD-DEN-14150-1 19 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

Remove #ifndef and remove the center condition (msgID <= END_OF_MSG_IDS -1).

DG-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13834-1 12 Oct 2022

This event is used for NV data management events. HD_EVENT_NO_EVENT is not currently in use.

HD-DEN-13903-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 04 Oct 2022

Remove isPOSTComplete.

DG-DEN-13834-1 12 Oct 2022

0V is expected.

DG-DEN-13834-1 12 Oct 2022

Either indent code block above or pull back the break to align.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 04 Oct 2022

Align "=".

HD-DEN-13834-1 29 Sep 2022

Why no stop?

DG-DEN-13834-1 04 Oct 2022

If this function is not yet needed, should we remove or at least put a #ifdef PHASE_1B build flag around it? Otherwise this is dead code right now.

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 21 Oct 2022

Remove blank line.

HD-DEN-13801-1 21 Oct 2022

Remove extra blank line.

HD-DEN-14101-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13903-2 12 Oct 2022

This seems very similar to condition above. Is this a merge issue? Do we need both?

HD-DEN-13903-2 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14166-1 21 Oct 2022

Done.

HD-DEN-14166-1 21 Oct 2022

Done.

HD-DEN-13801-1 21 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13903-2 18 Oct 2022

Update function header