•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13834-1 29 Sep 2022

It seems correct to me.

DIALIN-DEN-13460-1 29 Sep 2022

RESOLVED.

HD-DEN-14150-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 29 Sep 2022

These are defined in the Code Composer project for DG and HD firmware respectively. You can only have one defined and you must have one defined.

HD-DEN-13834-1 13 Oct 2022

Why can't we rename them ourselves? Let's just do it now.

HD-DEN-14000-1 12 Oct 2022

Can we assign request_type here at declaration instead of below?

HD-DEN-13834-1 29 Sep 2022

Faults (HD and DG) should probably be consistent on clear immediate concept. I think faults should be TRUE on clear immediate (going to fault mode anyway, so alarm condition isn't relevant after that).

HD-DEN-14000-1 07 Oct 2022

This works, but convention has been to use a local byte ptr and increment between param memcpy calls (see other message handlers).

DG-DEN-13834-1 12 Oct 2022

For the overrides, if the sensor is not in range, the command is just ignored.

HD-DEN-13903-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

This is not called in the ModeInitPOST. Right now, it does not do anything.

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13903-2 12 Oct 2022

FIXED IN CODE WALKTHROUGH

HD-DEN-13903-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13903-1 28 Sep 2022

Is adcDialInPumpMCCurrentmA an output?

DG-DEN-13834-1 06 Oct 2022

Should there be an alarm if loadCellID is invalid?

DG-DEN-13834-1 12 Oct 2022

1V is expected.

DG-DEN-13834-1 04 Oct 2022

Can this declaration be moved to top of function?

DG-DEN-13834-1 04 Oct 2022

Is this 109?

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 07 Oct 2022

Should break out of loop here I think.

HD-DEN-13903-2 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 29 Sep 2022

No stop property for a high priority alarm?

HD-DEN-13834-1 28 Sep 2022

Update function header.

HD-DEN-13834-1 28 Sep 2022

Update function header.

HD-DEN-13834-1 12 Oct 2022

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

HD-DEN-14001-1 18 Oct 2022

Done.

HD-DEN-14001-1 28 Sep 2022

doxygen tags.

HD-DEN-14101-1 19 Oct 2022

Merged Staging. Usage is seen in the init function.

HD-DEN-14150-1 19 Oct 2022

Uncomment this line.

HD-DEN-13903-2 12 Oct 2022

Wouldn't we set primeFirstPurgePass to FALSE here (we've just completed first pass and we're leaving)? And so shouldn't we just set BP to the faster rate now?

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13903-2 21 Oct 2022

Fixed. Using the old style for now. Will rework both alarms to use new persistence when we revisit the dialyzer timeout alarms in priming.

HD-DEN-13903-2 12 Oct 2022

Should have an else here where we reset (zero) airTrapIllegalLevelSensorsCtr.

HD-DEN-13903-2 21 Oct 2022

Fine for now. This one should probably just reset to zero on else instead of decrement.
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14166-1 20 Oct 2022

Commented out for testing?

DG-DEN-13786-1 24 Oct 2022

Why is RTC POST disabled?

DG-DEN-13786-1 24 Oct 2022

Alphabetize - move toward top of includes.

DG-DEN-13786-1 24 Oct 2022

Remove extra blank line.

HD-DEN-13801-1 25 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Remove commented out line of code.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 03 Oct 2022

fpgaPersistentAlarmGroup is an input.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.