•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 12 Oct 2022

Add // MSG_ID_... comment above prototype.

HD-DEN-13834-1 28 Sep 2022

Update function header. dgDialysateFlowDataFresFlag.

HD-DEN-13834-1 04 Oct 2022

Keep blank line.

HD-DEN-13834-1 29 Sep 2022

What is the purpose of this "no event" event?

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14170-1 08 Nov 2022

Updated else only with rampSyringePump().

HD-DEN-14175-1 09 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-14175-1 09 Nov 2022

Done.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14316-1 21 Nov 2022

Update header.

HD-DEN-14344-3 22 Nov 2022

Need function header.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14197-1 21 Nov 2022

Input is integratedVolumeML

DG-DEN-14197-1 21 Nov 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14197-1 21 Nov 2022

Alignment.

DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14197-1 21 Nov 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14197-1 21 Nov 2022

Change voltage to duty cycle.

DG-DEN-14197-1 21 Nov 2022

inactiveReservoir is the correct variable name. it is defined at line 752 within this same function.

In our current staging branch, this is named inactiveRsrvr. In develop, it's inactiveReservoir. Note that commit 2b6abbe does not show the change of name.

Regardless, it compiled when merging the working branch into develop. using crtl+f within the file shows that no other variable has the name inactiveRsrvr in my working branch. Using code composer's "Open declaration" of the variable points to to this data structure with this name.

/// Heaters data structure
typedef struct

F32 targetTemp; ///< Heater target temperature.
HEATERS_STATE_T state; ///< Heater state.
BOOL startHeaterSignal; ///< Heater start indication flag.
BOOL isHeaterOn; ///< Heater on/off status flag.
F32 dutyCycle; ///< Heater duty cycle.
F32 targetFlow; ///< Heater target flow.
BOOL hasTargetTempChanged; ///< Heater target temperature change flag indicator.
F32 heaterEstGain; ///< Heater estimation gain during the run.
BOOL hasTargetBeenReached; ///< Heater flag to indicate whether the target temperature has been reached.
F32 calculatedTemperature; ///< Heater calculated temperature.
DG_RESERVOIR_ID_T inactiveRsrvr; ///< Heater inactive reservoir.
HEATER_STATUS_T;

in heaters.c


So this is an odd one. maybe something got mixed up in a merge conflict?

DG-DEN-14000-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

HD-DEN-14344-3 22 Nov 2022

Oh, ok. Then somebody removed a blank line previously and should not have.
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Shouldn't make changes outside of user code scope. Looks like blank line added - remove.

HD-DEN-14344-3 22 Nov 2022

What happened here? Why changed?

DG-DEN-14316-1 21 Nov 2022

Alignment

HD-DEN-14344-3 23 Nov 2022

Function removed. Thanks!

HD-DEN-14344-3 23 Nov 2022

Fixed. Thanks!

HD-DEN-14099-1 29 Nov 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14344-3 28 Nov 2022

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13598-2 27 Sep 2022

Restored code.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13598-2 27 Sep 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13598-2 27 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15367-1 12 Jun 2023

Done

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 28 Sep 2022

Done.

DG-DEN-13834-1 28 Sep 2022

This was because I merged staging into my branch. I has been removed again.

HD-DEN-13834-1 29 Sep 2022

Done.