Is this resolved now? Can we un-comment this code?
RESOLVED in CODE WALKTHROUGH.
Monitor execs should be before operation modes exec.
Removed. Done.
Done.
Fixed. Thanks!
Please convert the self. valve names within DGValves to use this class.
I think it's abbreviated - should be spelled out (inactiveReservoir) I think.
Alignment
Should the pending alarm state be set here?
Fixed. Thanks! This complied with no issue... it was thinking inactiveRsrvr was from the inactiveRsrvr within the HEATER_STATUS_T data structure.
Remove commented code.
Based on function name, this function only expects to change step limit. So shouldn't need to pass signalID as param and shouldn't need a switch.
Update header. systemREG1 input and output.
RESOLVED IN CODE WALKTHROUGH
This comment looks like the same as the previous one? I am not sure. Please have team discussion about this.
Thanks, Fixed.
Done
Update function header.
This is part of the SRSs. This alarm is uncommented and is running.
Need F. Magic numbers need #defines?
RESOLVED IN CODE WALKTHROUGH.
Is this a start time (stamp) or a timer (count down/up)?
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
