Prefer normal if else for calling functions. I see these throughout.
RESOLVED in CODE WALKTHROUGH.
This implementation is not required right now. We are not calibrating temperature sensors.
What is this comment?
In V3, when TRo is requested, the firmware send the value of TDi.
No this line is a temporary line until the pump control is fixed so the 100 mL/min can be achieved.
Fixed. Thanks!
Why are we not checking payload length?
Updated.
Done.
Done. The ranks will be redefined.
Add TODO to restore to 100 when DPi flow control is fixed.
Remove blank line.
Is adcDialInPumpMCCurrentmA and output?
Should be 111.
This file has been removed in commit 851ee57 and then added again in commit 256d5cb
Lets get this question answered. I don't see the harm in having a max flow. I can't imagine we're ever seeing that much flow, so not sure why this has to be commented out while we sort out its existence.
Should say "private definitions".
Convention is to ack when receiving one-shot (not broadcast) messages like this.
Convention is to put spaces around operators like = and <.
Why no stop?
Uncomment line.
What are all the blank lines?
Move blank line from above to below declaration.
Why are we setting BP speed here? Wouldn't BP already be setup prior to this state? What does fluid at lower level have to do with BP speed?
Update function header.
RESOLVED IN CODE WALKTHROUGH
This build switch has been removed.
Removed
Alphabetize (move toward top of includes).
Magic #?
I think this should probably be reset elsewhere. Init function and on exit of retract maybe?
This else has been removed
Make #define for 0.5.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
