•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14166-1 21 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14166-1 20 Oct 2022

Use BOOL instead of U32 for sizeof checks since it is a BOOL that you are copying into. Same size, but want to be consistent.

HD-DEN-14101-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

Add TODO to comment.

DG-DEN-13786-1 24 Oct 2022

Change was made to get around earlier issues. Need discussion on whether or not to change back.

DG-DEN-13786-1 24 Oct 2022

Removed.

DG-DEN-13786-1 24 Oct 2022

Removed.

DG-DEN-13786-1 24 Oct 2022

Done.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE).

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Remove blank line.

HD-DEN-13801-1 28 Oct 2022

Restore blank line between functions.

HD-DEN-13801-1 28 Oct 2022

Remove commented out line of code.

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14150-1 03 Nov 2022

Add a space between "return" and "(".

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13598-2 29 Aug 2022

Do we need counters since we're using persistent alarms?

DG-DEN-12931-1 04 Aug 2022

Will address in DEN-13460.

UI-DEN-15279-1 12 Jun 2023

Thanks,
Fixed.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13141-6 16 Aug 2022

Removed blank lilne.

DG-DEN-12974-1 17 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 12 Aug 2022

This code will be updated to be consistent with the getRsrvrFillStatus from FLUSH mode.

DG-DEN-12974-1 12 Aug 2022

This code will be updated to be consistent with the getRsrvrFillStatus from FLUSH mode.

HD-DEN-13141-6 16 Aug 2022

/*@)/ appears to be the last line in all files? Should it put back in. Must be a doxygen command.

HD-DEN-13141-6 16 Aug 2022

Yes. And don't mark replies as requiring resolution.

DG-DEN-12974-1 16 Aug 2022

This code will be updated to be consistent with the getRsrvrFillStatus from FLUSH mode.

DG-DEN-12974-1 16 Aug 2022

Removed in ed6af22

DG-DEN-12974-1 16 Aug 2022

Removed in ed6af22

DG-DEN-12974-1 16 Aug 2022

Corrected.

HD-DEN-13141-6 17 Aug 2022

Bill, I was just asking why there was a blank line added before final } of last function. The doxygen end group stuff should stay.
I will generally add my comments directly below the issue, not above.

HD-DEN-13167-1 16 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13167-1 16 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13167-1 16 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 16 Aug 2022

Removed in ed6af22

DG-DEN-12974-1 16 Aug 2022

Corrected.