I already removed the test code (at line 116). I just checked and it was removed in my local version. I already pushed DEN-14150. Please pull it gain to see if the test code is still there. Thank you.
Testers requested the feature as feed back voltage. see http://dvm-linux02:8080/browse/DIAL-212
The static variable name is roPumpFeedbackDutyCyclePct. We get data from the INT_ADC_RO_PUMP_FEEDBACK_DUTY_CYCLE register on the FPGA in execROPumpMonitor/
No issue renaming it but is it a voltage or a duty cycle?
Is this a placeholder? Should have a "TODO" comment for the planned updates. Are the flow profiles intended to change eventually? Do some of these states have different pump load conditions? Test/tuning plans? Where will setROPIFlowProfile() be called? etc.
Added define. There is no harm in closing valve if already closed. TODO comment below is a place holder for checking if closed too long. More testing by systems needed to determine if this is necessary.
Should use get function instead of filtered.... We would want override to affect this check. Probably means we have to move this check to function that calls this function after override structure is set to new estimate.
Done. I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLMin() instead of using filteredDialinFlowMeterReading.
No stop property for a high priority alarm? PRS 754 says dialysate temperature alarms are low priority. Temp too low = rank 902. Temp too high = rank 901.
