•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14344-3 28 Nov 2022

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

DG-DEN-14316-1 30 Nov 2022

Remove.

DG-DEN-14316-1 30 Nov 2022

Remove.

DG-DEN-14316-1 30 Nov 2022

Remove.

DG-DEN-14316-1 30 Nov 2022

Alignment

DG-DEN-14316-1 21 Nov 2022

Alignment and commented out code.

HD-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-12931-2 03 Aug 2022

I thought exiting the normal state is the last request we want to check after making sure nothing else is requested.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 16 Oct 2024

Done

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1 12 Jun 2023

Update function header.

DG-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13598-2 26 Sep 2022

I didn't comment out the checkDialysateTemperature() function. I will ask the author of this function to see why it is commented out.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Align comment.

DD-LEAH-225-1 16 Oct 2024

Recommend U32 for i and currentLevelStatus.

DG-DEN-13834-1 28 Sep 2022

Yes, do you see any logic issues in the statement?

HD-DEN-13834-1 29 Sep 2022

Done.

HD-DEN-14001-1 30 Sep 2022

Keep multiple reads of remaining capacity and status in the switch as before.

HD-DEN-14000-1 10 Oct 2022

Updated.

HD-DEN-14000-1 10 Oct 2022

Updated.

DG-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-13460-1 29 Sep 2022

I think we do want to switch over to using the conversion function. Not necessarily the highest priority task since old way works too.
If creating a new sync function, let's use conversion function. If modifying an existing sync function, change to using conversion function is optional but preferable.

HD-DEN-13834-1 13 Oct 2022

I don't understand. It's used by nv data but it's not currently used? This enum is supposed to an enum of events that can be sent to UI for logging. Why would we want to log a non-event?

HD-DEN-14001-1 04 Oct 2022

Cases should be pulled back one indent (4 spaces) to align with others.

DG-DEN-13834-1 12 Oct 2022

The first loop is used to convert the counts to pressure once enough counts have been collected. The second loop is to monitor the pressure sensors all the time.

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13834-1 12 Oct 2022

Done.

HD-DEN-13903-2 12 Oct 2022

Remove blank line.

HD-DEN-13903-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13903-1 12 Oct 2022

Remove extra blank line.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 04 Oct 2022

Remove extra blank line.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 12 Oct 2022

This probably warrants a comment.

HD-DEN-13834-1 04 Oct 2022

Add another blank line here.

HD-DEN-13834-1 28 Sep 2022

Update function header.

HD-DEN-13834-1 28 Sep 2022

Update function header. dgReservoirsDataFresFlag.

HD-DEN-13834-1 17 Oct 2022

Done.

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14150-1 18 Oct 2022

Removed the commented-out line.

HD-DEN-14150-1 18 Oct 2022

SW_CONFIG_ENABLE_VALUE should be first item in conditional when checking against ==

HD-DEN-14001-1 28 Sep 2022

doxygen tags