•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-8030-1 04 Jun 2021

Please keep this case in last position in switch statement.

DG-DEN-8030-1 04 Jun 2021

Why commented out?

DG-DEN-8030-1 04 Jun 2021

Remove comments or add TODO.

DG-DEN-8030-1 04 Jun 2021

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

DG-DEN-8030-1 04 Jun 2021

I think we can remove this test code now.

DIALIN-DEN-7605-1 03 Jun 2021

This is Dara's code. Dara will fix in his DIALIN-DEN-8030 branch.

DIALIN-DEN-8462-1 03 Jun 2021

should we create dg_defs file?

DIALIN-DEN-7605-1 03 Jun 2021

Fixed.

DIALIN-DEN-7605-1 03 Jun 2021

RESOLVED

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7605-1 03 Jun 2021

RESOLVED

DIALIN-DEN-7605-1 01 Jun 2021

In _init_.py you should add from .checks import * so that someone can import the check from utils without having to know which file it is in

DG-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-8103-1 03 Jun 2021

Removed this extra flag.

HD-DEN-8103-1 03 Jun 2021

Removed this extra flag and used alarm status noNewTreatment flag.

HD-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-8103-1 03 Jun 2021

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

HD-DEN-8103-1 03 Jun 2021

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

HD-DEN-8103-1 03 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-9480-1 11 Nov 2021

RESOLVED.

HD-DEN-8103-1 03 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8103-1 03 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8103-1 03 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9480-1 10 Nov 2021

Add dgPOSTResultReceived in Outputs

DG-DEN-8103-1 03 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9480-1 10 Nov 2021

Remove valvesPostionOverride from both Inputs and Outputs

DG-DEN-8103-1 03 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8103-1 03 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 03 Jun 2021

Done.

HD-DEN-8103-1 04 Jun 2021

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

HD-DEN-8103-1 04 Jun 2021

The flag is latched by using OR with the local updated noNewTreatment status.

HD-DEN-7605-2 07 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 07 Jun 2021

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

HD-DEN-7605-2 04 Jun 2021

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

HD-DEN-8103-1 03 Jun 2021

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

HD-DEN-8103-1 07 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 03 Jun 2021

Is this different than alarmStatus.noNewTreatment?

HD-DEN-8103-1 07 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 07 Jun 2021

Per Dara Navaei, we will need to implement this functions.

HD-DEN-8103-1 07 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 07 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 03 Aug 2022

Done. We usually define the state at the top so for consistency, I defined the state first.

DG-DEN-12931-1 03 Aug 2022

Done.

HD-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-12931-2 03 Aug 2022

This can be reached in VC since it is not in a for loop.

HD-DEN-15367-1 12 Jun 2023

Done

HD-DEN-12931-2 03 Aug 2022

Removed the code.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 01 Aug 2022

Remove comment at end of line. Is fpgaReadByteSize replacing sizeof(DG_FPGA_SENSORS_T)?