Done.
We have to make sure the enable/disable feature in the software releases is not available in the release.
RESOLVED IN CODE WALKTHROUGH.
Wont these alarms be with an unknown alarm id for hd? it is created but not assigned.
Why no SW Config in Release?
RESOLVED in CODE WALKTHROUGH.
Blank line between declarations and code.
Why not just increment in the if statement below?
Do we still need this?
This variable cannot be initialized here, otherwise it will set the flag to FALSE regardless of the user's request.
Should we s/w fault if not a valid bottle?
RESOLVED
It is not broadcast all the time. It is sent per request.
I not I understand the answer and how that related to my question. I think what I am trying to say is:
And could you please help understand what is "QoL feature"?
Agree with Behrouz's initial proposed change above.
Removed the message.
Will be addressed in in DIAL-171.
Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).
Retract issue - looking at latest code it is needed. Else and mode change request restored. RESOLVED in CODE WALKTHROUGH.
RESOLVED IN CODE WALKTHROUGH
Remove valvesStatus from Inputs
Remove valvesPostionOverride from Inputs
Reviewed requirement - it is obsolete.
Removed ( TRUE == checkDialysateTemperature() )
couldnt we simplify this and compare it to a struct of the payload? (ex: UI_VERSIONS_T)
Added test separator below /*************************************************************************
I would move this to end of function in case state machine changes the state.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
