•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-12224-7 21 May 2022

Remove blank line.

HD-DEN-12224-16 25 May 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12358-1 08 Jun 2022

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_class and it ends up interfering with their data collection.

DIALIN-DEN-12358-1 09 Jun 2022

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary.

alarm_cto[0] == 1

it is double the unnecessary work and confusing.

HD-DEN-12961-1 13 Jun 2022

Moved code as suggested.

HD-DEN-12961-1 13 Jun 2022

Moved code as suggested.

DG-DEN-12845-2 13 Jun 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12845-2 25 May 2022

I don't think we need to broadcast usage data regularly (like every second), but may want to send it once in a while to get logged - maybe when we transition to treatment mode to start a new treatment.

HD-DEN-12845-2 25 May 2022

Too many parenthesis in first part of condition I think.

HD-DEN-12845-2 25 May 2022

Space before final parenthesis.

HD-DEN-12609-2 14 Jun 2022

Should probably log ms - so need to multiply by task interval.

DIALIN-DEN-8514-1 28 May 2021

Thanks for catching that,
Fixed.

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-9480-1 10 Nov 2021

remove valveSeftTestState from Inputs and put it in Outputs.

DG-DEN-11928-1 22 Mar 2022

Should this mode request be moved to last state as we transition to this state.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-12847-1 30 Jun 2022

Per conversation with Sean: It is a DG Fault generated that the HD is identifying.

DIALIN-DEN-12358-1 28 Jun 2022

QoL feature = Quality of Life feature.

It is a feature for users (V&V and sys) that allows them to exercise the API and generate tests faster. Breaking this current design would cause some major refactoring for them as they expect the HD and DG classes to have the sub modules loaded.

We can look into the technical performance in http://dvm-linux02:8080/browse/DIAL-172

HD-DEN-12224-16 25 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-12224-16 20 May 2022

Ask Behrouz if UI is still looking for this. Remove if not.

HD-DEN-12224-16 22 May 2022

Removed the release check.

HD-DEN-12224-16 23 May 2022

Done.

HD-DEN-12224-16 23 May 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-12224-16 20 May 2022

Remove extra blank line. And why is there any blank line here?

DG-DEN-12224-7 22 May 2022

Is this the best place to do this?

DG-DEN-12224-7 21 May 2022

Makes me a little nervous that hdMode is never initialized.

DG-DEN-12224-7 21 May 2022

Add doxygen comments.

DIALIN-DEN-12358-1 14 Jun 2022

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans.
If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly.
I think the current way this assignment is coded is making no assumptions and explicitly converting integer to boolean which is ok with me.

DG-DEN-12224-7 25 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 25 May 2022

This will be addressed in DEN-12931.

HD-DEN-12961-1 13 Jun 2022

Moved code as suggested.

HD-DEN-12845-2 13 Jun 2022

Done.

HD-DEN-12961-1 10 Jun 2022

Does this need to be moved above the first condition?

DG-DEN-12845-2 13 Jun 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12845-2 20 May 2022

Align comment.

DG-DEN-12845-2 20 May 2022

Remove one of these blank lines.

HD-DEN-12845-2 25 May 2022

Too many parenthesis in first part of condition I think.

HD-DEN-12845-2 25 May 2022

Spaces between parenthesis and condition.

HD-DEN-12845-2 13 Jun 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12974-1 28 Jun 2022

Seems like isADCValid should be returned.