•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-12847-1 13 Jul 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12931-2 12 Jul 2022

Update input/outputs throughout.

DIALIN-DEN-8514-1 28 May 2021

Thanks for catching that,
Fixed.

DIALIN-DEN-8514-1 28 May 2021

Missing .value

DG-DEN-13598-2 26 Sep 2022

RESOLVED in CODE WALKTHROUGH

DIALIN-DEN-8514-1 01 Jun 2021

RESOLVED

DIALIN-DEN-8308-1 01 Jun 2021

RESOLVED

TD-LDT-1886-7 20 Oct 2025

Done

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12215-2 08 Mar 2022

I think you have these switch checks in the right pre-treatment sub-modes, but I think each of these sub-modes will have a "stopped" state in its state machine where it will go if an alarm occurs and in that state the user should be allowed to open the door to possibly address the issue.
So I think we need to figure out how to exempt those alarm states.

HD-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALTHROUGH.

HD-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-11928-1 22 Mar 2022

Add doxygen comment.

HD-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-9480-1 10 Nov 2021

should be none in Inputs:

HD-DEN-9480-1 10 Nov 2021

@details Outputs: valvesSelfTestResult, valvesStatus

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-9480-1 10 Nov 2021

Remove valvesStatus from @details Inputs.

UI-DEN-12258-1 08 Apr 2022

Does it bother CoCo if you disable a begin but leave the end there?

HD-DEN-12441-3 11 May 2022

Done

HD-DEN-12441-3 11 May 2022

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

HD-DEN-12224-16 18 May 2022

We will want to tighten these eventually.

HD-DEN-12224-16 20 May 2022

Seems like we're setting a start time offset here, not a time stamp.

HD-DEN-12224-16 22 May 2022

Done.

HD-DEN-12224-16 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

hdMode is initialized now.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

Done.

HD-DEN-12224-16 23 May 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 20 May 2022

Should be rpmAlarmStartTime

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 22 May 2022

Swap if order.

DG-DEN-12224-7 21 May 2022

Add another blank line.

DG-DEN-12224-7 21 May 2022

Add a blank line between declarations and code.

DG-DEN-12224-7 21 May 2022

Can we finalize this fault now?

DG-DEN-12224-7 21 May 2022

Why aren't all fields initialized here?

DG-DEN-12224-7 21 May 2022

Should be NUM_OF_SWITCHES based on enum name and type. Also, no doors - fix comment.

HD-DEN-12224-16 20 May 2022

Should we exit blood leak normal mode in here somewhere?

DG-DEN-12224-7 25 May 2022

RESOLVED in CODE WALKTHROUGH.