RESOLVED IN CODE WALKTHROUGH
Inputs should be none
updated pre-gen alarms that fault to rank 10
RESOLVED.
RESOLVED in CODE WALKTHROUGH.
Already removed the variable. No more needed.
Done.
Changed COND_SENSOR_CPI_WARNING_HIGH to COND_SENSOR_CPI_WARNING_LOW
Ok
Per our coding style, please use ternary for these two booleans: isConductTooLow = ( conductivity <= COND_SENSOR... ? TRUE : FALSE )
Wait here for alarm is no longer active, then transition to fill mode.
This was part of the merge from staging branch.
Should just set result to this state above at declaration to simplify.
We can't initialize bad fill state here because this init function gets called every time we come back to idle mode. I think we should initialize the badFillState in the start state when we decide to go to the flush water (normal) state.
Remove commented out requests to go to idle mode.
Same here [ using conversaions.py ]
Dara removed this line of code after lab test w/o this change could not replicate the bug.
So then when would we remove this line of code?
Why only comment out? Can't we just remove?
I don't usually remove these kinds of comments they are there for developers as a reminder to keep the indices match. This is like a code comment.
When will this get fixed (removed)?
By "case", you mean a Jira bug? Sure, we can do that.
Mike, can you please look at updating these (and perhaps many others throughout Dialin)?
Done
I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.
It is used on lines 302, 1172, 1795, 1875.
Why is this necessary. This is already called somewhere else.
Should this be set to FALSE?
One letter enums could be more descriptive with their names.
Thanks for catching that, Fixed.
RESOLVED in CODE WALKTHROUGH
copy paste error comment
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
