•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11928-1 18 Mar 2022

Removed TARGET_FLUSH_WATER_RO_FLOW_RATE_L

DIALIN-DEN-9480-1 11 Nov 2021

This is considered as an optimization. I will implement it in DEN-11114.

DIALIN-DEN-9480-1 11 Nov 2021

There are 2 returns in this function and why @return: None here?

HD-DEN-13598-2 26 Sep 2022

Done. Removed the variable, no more needed.

DG-DEN-11928-1 21 Mar 2022

Added
startFillCmd( targetFillVolumeML, getTargetFillFlowRateLPM() ); // refill to the saved target fill volume (~1500 mL)

HD-DEN-13598-2 27 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 21 Mar 2022

Removed setBottlesNeedPrimeFlag and use function setThisFirstFillFlag().

DG-DEN-11928-1 22 Mar 2022

Added internal signal flag handleBadFillFlag

HD-DEN-12224-16 23 May 2022

Michael Garthwaite do you have the latest tolerances after your testings?

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11928-2 22 Mar 2022

Just delete this line of code.

DG-DEN-11928-1 18 Mar 2022

Don't need this volume variable. You are only initializing it and then never using it.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12224-1 07 Apr 2022

We had a conversation with Michael Garthwaite and all these functions are going to use the functions in the conversions.py since this method of doing it is very error-prone.
We should plan soon to make these changes.

HD-DEN-12224-16 23 May 2022

Done.

HD-DEN-12441-3 11 May 2022

What is the purpose of this new code? Should have a comment above to make clear.
Need to address TODOs.

DG-DEN-12224-7 25 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 20 May 2022

Why isn't this command allowed for release version?

HD-DEN-12224-16 20 May 2022

Is this zero temporary? If so, add TODO.

HD-DEN-12224-16 18 May 2022

"reset" should be "rest" I think.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 18 May 2022

NoDRcr should be FALSE.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 24 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 18 May 2022

Should we set this flag only if we are in normal state?

DG-DEN-12224-7 25 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 25 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 25 May 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12358-1 07 Apr 2022

It is big data to be reserved and filled with just default values, There should be a better way.

HD-DEN-12845-2 13 Jun 2022

We got recommendation to monitor arterial pressure even when not dialyzing if patient is still connected (so all other treatment mode states other than dialysis when not delivering saline bolus), but didn't want to apply the user provided limits - just want to monitor for max pressure situation.

DG-DEN-12845-2 13 Jun 2022

Done.

HD-DEN-12845-2 13 Jun 2022

Done.

HD-DEN-12961-1 10 Jun 2022

Looks like this is in wrong spot.

DG-DEN-12845-2 13 Jun 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12845-2 25 May 2022

Should log volume level before and after.

DIALIN-DEN-12224-1 20 Jun 2022

RESOLVED.

HD-DEN-12609-2 14 Jun 2022

Add space after ifs.

DG-DEN-12847-1 28 Jun 2022

Updated

DG-DEN-12847-1 28 Jun 2022

Remove blank line.

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

DIALIN-DEN-8514-1 28 May 2021

Missing .value at the end of the message id

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Why can't we use value for the same purpose as the actualValue?

HD-DEN-12215-2 10 Mar 2022

Added.

DG-DEN-13598-2 26 Sep 2022

RESOLVED in CODE WALKTHROUGH

DIALIN-DEN-9480-1 11 Nov 2021

RESOLVED.

DD-LEAH-225-1 16 Oct 2024

What is the difference between target temp and calculated target temp? I'm assuming this came from DG and probably not necessary in DD.

DIALIN-DEN-9480-1 11 Nov 2021

RESOLVED.

DG-DEN-9480-1 10 Nov 2021

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

HD-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH