I see a couple of issues here: The message response logic has been moved out of dialin and into your UI simulator in the testsuites respository. This creates a couple of problems: First, it upends the entire design of the HD / DG simulator. Second, it splits the responsibility for simulating an HD and DG into both dialin and your UI simulator program. This means that the caller of the dialin command must know how to construct a response. If I want to use your functions to simulate a response, I can't because they don't exist here. The logic for simulating an HD and DG must be fully contained inside the HD and DG simulators so other users of the API can call it, not dispersed to outside scripts. Also, your changes appear to be on an extremely old version of dialin. These changes are incompatible with the latest changes on staging. Please merge staging into your branch.
A message ID must not be passed to a simulator command. This ensures there is a one to one mapping between dialin commands and messages and that dialin can do its job of abstracting messages. This is how dialin works everywhere else and should not be changed.
Parameters should not be pre-converted to bytearrays before being sent to dialin.
If you have one, two, or five parameters in a denali message, your dialin function should accept one, two, or five parameters. This ensures the payload is clearly defined and described by the number of parameters passed to the function and that the function can do its job of abstracting the denali message.
We need to wait in this state (don't fill yet) if the first alarm has not yet been cleared by user (indicating user has confirmed replacement of bottles). So need an "if" here. Also, we need to do something so that the next fill will only go to 1,000 mL.
Sure Sean, if that is the decision, will do it soon and create a case for that. I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CANBus).
Issue DEN-13441 - MR: Make the Dialin log permanent with no switch [CL switches review/removal] has been successfully created
As we had a conversation, the V&V request can be covered in the effort of the three stacks checking their versions and compatibility, then a message can be sent over the HD channel.
