•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-7605-1 26 May 2021

Yes. Fixed.

DG-DEN-7605-1 26 May 2021

Fixed.

DG-DEN-7605-1 27 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7605-1 27 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7605-1 26 May 2021

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

DG-DEN-7605-1 27 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7605-1 26 May 2021

Should this be in interval count?

DG-DEN-7605-1 27 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8103-1 27 May 2021

Done.

HD-DEN-7605-2 28 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 28 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 28 May 2021

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have room for more than 50 alarms. Maybe high priority could be 1..499, medium priority 500..599, and low priority 600..699.

DG-DEN-8103-1 28 May 2021

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

DG-DEN-8103-1 28 May 2021

Why did this change?

DG-DEN-8103-1 28 May 2021

Should mention somewhere that timer is counting ms.

DG-DEN-8103-1 28 May 2021

Done.

DG-DEN-8103-1 28 May 2021

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

UI-DEN-8308-1 28 May 2021

RESOLVED

UI-DEN-8308-1 24 May 2021

The dialin usage is incorrect here. Please see my comments in the dialin code review.

DIALIN-DEN-8308-1 28 May 2021

RESOLVED

DIALIN-DEN-8308-1 28 May 2021

RESOLVED

DIALIN-DEN-8308-1 28 May 2021

The typing information is missing for accepted and reason here

DIALIN-DEN-8308-1 28 May 2021

Missing the cmd_ prefix in the function name

DIALIN-DEN-7820-1 28 May 2021

RESOLVED

DIALIN-DEN-8308-1 28 May 2021

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

DIALIN-DEN-8308-1 28 May 2021

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

DIALIN-DEN-8308-1 28 May 2021

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

DIALIN-DEN-8308-1 28 May 2021

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

DIALIN-DEN-8308-1 28 May 2021

Missing the cmd_ prefix in the function name

HD-DEN-8103-1 28 May 2021

We should delete this dead code as well.

DG-DEN-8103-1 28 May 2021

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

HD-DEN-8103-1 28 May 2021

Dara, do we need these handlers or not?

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

UI-DEN-13198-1 25 Sep 2022

A bug has been created for that.
I need to work on it and test it.
Please resolve and will follow up under the bug: DEN-14006

RO-LDT-1242-1 03 Sep 2025

fixed thanks!

DG-DEN-11928-1 18 Mar 2022

I don't think we should be using bad fill to make this decision. It will work first time but bad fill workflow will do 2 more fills that hopefully will not be bad fills and yet we still want to stay in the bad fill state until we finish the bad fill workflow.
So what I think we should be doing is having fill mode signal idle mode (call a signal function from fill mode when bad avg conductivity detected which sets a flag here in idle mode).

DIALIN-DEN-8514-1 28 May 2021

Instead of

MSG_ID_DG_DISINFECT_TIME_FLUSH 

It should be

MSG_ID_DG_DISINFECT_TIME_FLUSH.value
DG-DEN-11928-1 22 Mar 2022

Can't initialize this hear. Move to start state handler where we decide to do normal workflow.

DIALIN-DEN-7605-1 01 Jun 2021

Is there a problem with crc_16? Or, what needs to be fixed still?

HD-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-11928-1 22 Mar 2022

Removed flush lines

HD-DEN-12215-2 22 Mar 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-11928-2 22 Mar 2022

Just delete this line of code.

HD-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-9480-1 10 Nov 2021

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

HD-DEN-9480-1 10 Nov 2021

Update @details Inputs, and @detail Outputs as shown below:
@detail Inputs: None
@detail Outputs: valveSeftTestState, valveSeftTestResult, valveAirTrapStatus, valvesControlSetBits, valvesStatus

DG-DEN-11928-1 18 Mar 2022

Would also set internal signal flag to FALSE here so next call to idle exec will get us back into the normal flush water state.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.