•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-12215-2 10 Mar 2022

Added

UI-DEN-8495-1 25 May 2021

RESOLVED

DG-DEN-11928-1 22 Mar 2022

This mode request will not do anything. Need to change the main idle state to start state so it will take normal workflow path.

DG-DEN-11928-1 18 Mar 2022

Removed return.

DG-DEN-11928-1 31 Mar 2022

RESOLVED in WALKTHROUGH.

DG-DEN-11928-1 21 Mar 2022

At the end of drain, check for empty bottles

DG-DEN-11928-1 22 Mar 2022

Please do not remove the #defines until the calibration records are updated.

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 18 Mar 2022

2nd alarm probably doesn't need any data. 1st alarm will log the data.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12716-1 06 Jul 2022

RESOLVED.

DG-DEN-11928-1 18 Mar 2022

This looks like the second bad fill alarm. ClrIm should be FALSE, NoClr should be FALSE, and NoRes/NoRin/NoEnd should be FALSE.

DG-DEN-11928-1 22 Mar 2022

Don't need this else and request for idle.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12358-1 12 Jul 2022

In ticket http://dvm-linux02:8080/browse/DIAL-171

UI-DEN-12716-2 01 Jul 2022

This code is going to be used later in the Log Export for slow transfer & confirmation for the USB port slow transfer issue.
I kept it in the application repo to keep it safe.
Commented out to not affect the coverage.

UI-DEN-12716-2 06 Jul 2022

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin commands are always one-shot type messages, so will not impact log size.

DG-DEN-13460-2 26 Aug 2022

Remove todo in comment if it is resolved.

DIALIN-DEN-12358-1 12 Jul 2022

Please take care of it as soon as you found time.
It's quite a bit of time since we talked about and It's a month since I created a case for that.

RESOLVED for now.

HD-DEN-12847-1 13 Jul 2022

Done.

HD-DEN-12847-1 13 Jul 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 23 Jul 2022

Keep this blank line.

DG-DEN-12931-1 23 Jul 2022

Is this a TODO?

DG-DEN-12931-1 23 Jul 2022

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

DG-DEN-12931-1 01 Aug 2022

Remove comment at end of line? sam for 710/822.

DG-DEN-12931-1 23 Jul 2022

Magic number.

DG-DEN-12931-1 23 Jul 2022

Why are these commented out. I thought these were fixed now.

HD-DEN-12609-2 24 Aug 2022

Fixed. Thanks!

HD-DEN-12609-2 24 Aug 2022

Fixed. Thanks!

HD-DEN-12609-2 24 Aug 2022

Fixed. Thanks!

DG-DEN-13427-1 25 Aug 2022

Remove blank line.

HD-DEN-7860-1 19 May 2021

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 20 May 2021

Changed to use treatmentTimeMS to increase the log time.

UI-DEN-8495-1 24 May 2021

Updated

DG-DEN-9906-1 10 Nov 2021

I removed the alarm.

UI-DEN-8495-1 24 May 2021

Updated

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8308-1 24 May 2021

Updated regarding our conversation.

RO-LDT-1242-1 03 Sep 2025

just a placeholder for now ( until SA updates ). bumped it to 10 seconds in the meantime

UI-DEN-8495-1 25 May 2021

RESOLVED.

DG-DEN-12931-1 01 Aug 2022

Does the monitorPumpSpeed function generate the alarm

UI-DEN-8308-1 25 May 2021

RESOLVED

DG-DEN-11928-1 18 Mar 2022

I think 0xAD msg ID is taken. Looks like you haven't done a pull for common in a while - please do that. Also, when adding new messages, start in our shared message list spreadsheet - we need to keep that spreadsheet up to date.

UI-DEN-8308-1 25 May 2021

RESOLVED

UI-DEN-8308-1 25 May 2021

RESOLVED

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.