•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-12121-1 08 Mar 2022

For consistency, HD_PRIME_PAUSE and HD_PRIME_COMPLETE should have STATE at the end of their names.

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

UI-DEN-8308-1 25 May 2021

From what I can tell the dg command is separated from the hd command which is good.
Please let me know when your code is ready to be merged to staging and I will handle it.
Also for the next feature you're working on please branch off of the latest staging.

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DIALIN-DEN-12121-1 04 Mar 2022

Please add the simulator functions for the newly added models, like the:

  • DG Conductivity Data
  • HD blood leak data
  • HD air bubbles data
  • Air Trap Data
  • .....
DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 03 Mar 2022

remove empty

UI-DEN-12121-1 03 Mar 2022

fix the Src, and CAN ID.

UI-DEN-12121-1 03 Mar 2022
  • Fix the Src, Should be HD.
  • Fix the CAN ID, should be 0x040
DG-DEN-11928-1 18 Mar 2022

Done.

HD-DEN-12215-2 10 Mar 2022

Added exception for Stopped sub states and before door should be closed.

DG-DEN-11928-1 18 Mar 2022

Changed this function to private.

DG-DEN-11928-1 18 Mar 2022

Replaced with activateAlarmNoData.

DG-DEN-11928-1 18 Mar 2022

Set result = DG_HANDLE_BAD_FILL_STATE_START;

HD-DEN-12215-2 17 Mar 2022

What is the reason for these changes? Just reading the code, it makes more sense to me that way it was.

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12215-2 08 Mar 2022

I don't think this is the right place to clear alarm conditions. This area of code is updating the actual detected switch states. But switch states are overridable so we should consider any overrides when clearing alarm conditions.

HD-DEN-12224-16 30 Mar 2022

This variable is defined but not used.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALTHROUGH.

HD-DEN-11928-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 18 Mar 2022

Need to make sure this fill will target the normal fill volume (not 1,000 mL this time).

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 18 Mar 2022

Don't need this new #define. Already have 0.3 defined above with TARGET_RO_FLOW_RATE_L.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 04 Mar 2022

Do we need a warning high when we already have a max above with same value?

DG-DEN-11928-1 30 Mar 2022

Done.

DG-DEN-11928-1 31 Mar 2022

It is zeroed in transition function and it is not used until the acid state.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

Done.

DG-DEN-12224-7 24 May 2022

The idea was to call these variables once it is time to do the control but it was abandoned.

DG-DEN-12224-7 24 May 2022

Done.

HD-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12716-2 01 Jul 2022

Why must this be removed later?

UI-DEN-12716-2 01 Jul 2022

Why is main.cpp all commented out?

DG-DEN-9480-1 10 Nov 2021

Done.

DIALIN-DEN-7860-1 19 May 2021

Addressed.

DG-DEN-9906-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 19 May 2021

Data is packaging several pieces of information for both ADA and ADV air bubble detectors, hence, the grammar is plural. The other override functions are commanding on only one of the detectors depending on the index, hence, the grammar is singular.

HD-DEN-7860-1 19 May 2021

Same response here.

LEAHI-DIALIN-LDT-566-1 24 Jun 2025

added

DIALIN-DEN-7860-1 19 May 2021

RESOLVED

DIALIN-DEN-7860-1 18 May 2021

param is "status", not detected.

DIALIN-DEN-7860-1 19 May 2021

Addressed.

HD-DEN-8103-1 20 May 2021

Removed. UI will be the logger, so the clock comes from only one source.

UI-DEN-8495-1 24 May 2021

Updated

UI-DEN-8495-1 24 May 2021

Add TODO