•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-8308-1 25 May 2021

RESOLVED

DIALIN-DEN-7820-1 24 May 2021

It has been updated regarding our conversation.

DG-DEN-11928-1 18 Mar 2022

Removed flushWaterVolumeL.

UI-DEN-8308-1 24 May 2021

The original file didn't have the copyright so couldn't find easily what was the actual dates, just put some dates. Bamboo will later update the copyright with correct information.

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

UI-DEN-8308-1 25 May 2021

RESOLVED

UI-DEN-8495-1 25 May 2021

RESOLVED

DIALIN-DEN-12121-1 09 Mar 2022

Using 0xA008 as it is available instead

HD-DEN-12121-1 09 Mar 2022

Fixed. Changed Msg_id for this cmd to 0xA008 to prevent conflicts.

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED
Thanks,

DIALIN-DEN-12121-1 09 Mar 2022

Please remove the state in the @param state docstring.

RESOLVED
Thanks,

DIALIN-DEN-12121-1 04 Mar 2022

the docstring says it is bool, which is correct.

UI-DEN-12121-1 03 Mar 2022

remove the empty line.
lower the column alignment spaces.

UI-DEN-12121-1 03 Mar 2022

The message is a U16 and each valve is a bit, and it's not clear to me why the type has been changed from bool to a very big uint32 type?
Although it was defined as boolean, qml was showing it as an int value, so what are we going to achieve here?

DG-DEN-12121-1 10 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

Add doxygen comment.

DG-DEN-11928-1 18 Mar 2022

Idle mode calls
BOOL isAvgConductivityOutOfRange( void )

Unknown macro: { return fillStatus.fillAvgConductivityOutOfRange; }
HD-DEN-12215-2 08 Mar 2022

Similiar to how the check is done in ModePostTreat.c, I think we should check if the heparin parameters are > 0.0 than NEARLY_ZERO.

HD-DEN-12215-2 22 Mar 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

Updated to
BOOL const isConductTooLow = ( conductivity <= COND_SENSOR_CPI_MIN_VALUE ) ? TRUE : FALSE;

BOOL const isConductTooHigh = ( conductivity >= COND_SENSOR_CPI_WARNING_HIGH ) ? TRUE : FALSE ;

HD-DEN-12215-2 08 Mar 2022

If I understand what you did here, I think we're good updating from HALCoGen w/o breaking the build but if we change stack size(s) we will need to manually update the #if 1 section accordingly after HALCoGen updates this file.

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 18 Mar 2022

Is this the bad fill alarm (first one)? If so, let's change name to FILL_CONDUCTIVITY_OUT_OF_RANGE and I think clear immediate should be TRUE and no clear should be FALSE and clear only (UsrAck here) should be TRUE. Not sure if TxLog should be TRUE - I don't think so.

DG-DEN-11928-1 30 Mar 2022

deleted blank line

DG-DEN-11928-1 30 Mar 2022

Changed TxLog field from TRUE to FALSE

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-7860-1 19 May 2021

Addressed.

HD-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 18 Mar 2022

Done.

DIALIN-DEN-7860-1 18 May 2021

Should we have a get function for air_bubbles_state too?

HD-DEN-8103-1 19 May 2021

For UF, need to accumulate volume deltas or remember where 30 min volume started and then subtract from current volume when 30 minutes is up. Then convert to rate by dividing volume by 30 min.

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

This needs to be a #define line BAD_FILL_TARGET_VOLUME_ML

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8495-1 24 May 2021

V&V has requested to be able to get the version from the UI using dialin to automate their testing

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8495-1 24 May 2021

does not (instead of doesn't)

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED.

UI-DEN-8308-1 25 May 2021

RESOLVED

DG-DEN-11928-1 07 Mar 2022

Uncommented and recompiled without errors

DG-DEN-11928-1 07 Mar 2022

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );