•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 06 Mar 2022

Add a space.

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 06 Mar 2022

Why is this commented out?

HD-DEN-12215-2 09 Mar 2022

Sean said leave it as is. No harm to be done.

UI-DEN-12121-1 03 Mar 2022

please remove the empty line.

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

HD-DEN-12215-2 10 Mar 2022

Added.

DG-DEN-11928-1 18 Mar 2022

I think we tare just about every time we drain - so this path is very common and you are not checking for empty bottles here.

DG-DEN-11928-1 18 Mar 2022

Updated NoRin, NoEnd, ClrOnly to FALSE.

HD-DEN-12215-2 22 Mar 2022

It looks like staging branch has things the way it was too.

HD-DEN-11928-2 22 Mar 2022

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

HD-DEN-12215-2 08 Mar 2022

Out of scope of the changes here but hepRate should be getting TREATMENT_PARAM_HEPARIN_DISPENSE_RATE instead of TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME.

DG-DEN-11928-1 18 Mar 2022

This request for idle mode is already present at bottom of function.

DG-DEN-11928-1 18 Mar 2022

Last parameter should be warning low threshold I think.

HD-DEN-12931-2 04 Aug 2022

RESOLVED CODE IN WALKTHROUGH.

HD-DEN-12931-2 12 Jul 2022

Looks like exit normal request (below) will take precedence over this request. Is that intended?

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12931-1 04 Aug 2022

Done.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 18 May 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7860-1 19 May 2021

RESOLVED.

HD-DEN-9480-1 09 Nov 2021

Done.

DIALIN-DEN-7860-1 19 May 2021

RESOLVED.

DIALIN-DEN-8308-1 19 May 2021

RESOLVED.

DIALIN-DEN-8308-1 19 May 2021

RESOLVED.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 19 May 2021

The UI will provide this. Firmware will not have this value.

HD-DEN-8103-1 19 May 2021

Done.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-9480-1 09 Nov 2021

Convention has been to do the [0] tuple indexing when assigned to class variable below.
If doing the [0] tuple indexing here, we don't need these temporary variables - can assign directly to the class variables.

HD-DEN-8103-1 20 May 2021

It took around 55 ms for the largest section (.text). I have imposed a maximum size per each CRC calculation, which takes around 7 ms each.

UI-DEN-8308-1 24 May 2021

RESOLVED

UI-DEN-8495-1 24 May 2021

On the UI side, we have no plan, for now, to listen to Dialin.

DIALIN-DEN-9480-1 09 Nov 2021

I added the trimmer heaters state.

UI-DEN-8308-1 24 May 2021

The original file didn't have the copyright so couldn't find easily what was the actual dates, just put some dates. Bamboo will later update the copyright with correct information.

UI-DEN-8308-1 25 May 2021

RESOLVED

UI-DEN-8308-1 25 May 2021

RESOLVED

UI-DEN-8308-1 24 May 2021

Docstring is missing

UI-DEN-8308-1 25 May 2021

RESOLVED

UI-DEN-12121-1 03 Mar 2022

DG Accelerometer is not being used anymore?
If so we should put a TODO comment to remove the model/view later to keep the Application lighter.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 09 Nov 2021

No, the voltage is monitored in the RO pump module.

DG-DEN-9480-1 09 Nov 2021

I removed it.

DG-DEN-11928-1 04 Mar 2022

Let's review that requirement - may be obsolete.

DIALIN-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-11928-1 04 Mar 2022

Let's review requirement - may be obsolete.

DG-DEN-9480-1 09 Nov 2021

That if has an extra condition (beyond pump is not on). So alarm persistence is only reset if other condition is met. If other condition is not met, persistence is left in limbo.

DG-DEN-9480-1 09 Nov 2021

Done.