•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-9480-1 04 Nov 2021

Make a build switch to disable ACK alarms.

HD-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7860-1 21 May 2021

Is this print meant to be permanent? Or is it debug code?

DIALIN-DEN-9480-1 09 Nov 2021

Where is 0xA044?

UI-DEN-8495-1 24 May 2021

The UI is already talking with Dialin. Your simulator is using dialin to talk to the UI.
Because the UI doesn't recognize Dialin at all, Dialin has to talk on the HD to UI or DG to UI channels instead when sending up commands to the UI.
This poses a security risk because the UI could never restrict communication to just the DG/HD only. If Dialin can talk to the UI on separate channels then those channels can be ignored in production mode later.

It's your stack so your call but something I think we should consider

UI-DEN-8308-1 24 May 2021

It has been updated regarding our conversation.

UI-DEN-8308-1 24 May 2021

It has been updated regarding our conversation.

UI-DEN-8495-1 25 May 2021

RESOLVED.

UI-DEN-8495-1 25 May 2021

RESOLVED.

UI-DEN-8495-1 24 May 2021

remove the before anything

UI-DEN-8308-1 25 May 2021

RESOLVED

DIALIN-DEN-7820-1 25 May 2021

It has been addressed in another code review for another branch (TxLog , Disinfection).

DIALIN-DEN-7820-1 25 May 2021

The fromHD flag should be removed since there is a separate dg simulator

HD-DEN-7860-1 18 May 2021

I don't see changes to HD fluid leak. DG fluid leak function header looks ok as is. RESOLVED in CODE WALKTHROUGH.

TD-LDT-1886-7 20 Oct 2025

Done

HD-DEN-7605-2 18 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7860-1 19 May 2021

Addressed.

UI-DEN-10206-1 04 Nov 2021

Updated in the latest branch, The Link is attached.

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7860-1 19 May 2021

None of the functions we have check for any of these conditions. If we want to implement this in the code, we will need to remove this comment from all *.py Dialin API files and implement the checks in all *.py Dialin API files. Please let me know how you would like to proceed.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 19 May 2021

Done.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8251-1 21 May 2021

Will this path is enough to find dialin folder since this has been moved into another folder?

HD-DEN-12215-2 08 Mar 2022

Should we check pump track switch too?

UI-DEN-8308-1 24 May 2021

Correct,
A repository will be created for this tool very soon, but still, the executable will be here regardless.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 20 May 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 03 Mar 2022

HD Accelerometer is not being used anymore?
If so we should put a TODO comment to remove the model/view later to keep the Application lighter.

HD-DEN-7860-1 20 May 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7860-1 20 May 2021

RESOLVED.

DG-DEN-9480-1 06 Nov 2021

With 2400 RPM the flow rate was ~2497.718 mL/min. I changed the target RPM to 2300.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 19 May 2021

How long does this take? We may need to break this loop into smaller pieces and have ModeInitPOST call this function multiple times so that general task does not take too long (> 40ms or so). Otherwise, watchdog will not get pet within its ~50ms window and expire - and also other general and background operations will be blocked until this test is completed.

DG-DEN-9480-1 06 Nov 2021

Done.

UI-DEN-8308-1 24 May 2021

added

UI-DEN-8308-1 25 May 2021

RESOLVED

UI-DEN-8308-1 24 May 2021

Should the log file be added to the repository?

DIALIN-DEN-9906-1 06 Nov 2021

Yes that is right. Please ignore the copyright section, the Bamboo staging build will check all of those.

UI-DEN-8308-1 25 May 2021

I don't have dg_simulator.
It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.

DG-DEN-7605-1 19 May 2021

Align comment.

DG-DEN-9480-1 09 Nov 2021

Done.

DG-DEN-9480-1 09 Nov 2021

I added an else to FALSE the persistent alarm.

DG-DEN-11928-1 04 Mar 2022

So do we need a different #define for the 40?

HD-DEN-9480-1 09 Nov 2021

Fixed the code.

HD-DEN-9480-1 09 Nov 2021

Done.

DG-DEN-11928-1 07 Mar 2022

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

HD-DEN-9480-1 09 Nov 2021

Done.

DIALIN-DEN-9480-1 10 Nov 2021

Done.