•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 18 May 2021

Remove extra line.

DIALIN-DEN-7860-1 19 May 2021

Addressed.

DG-DEN-7605-1 15 May 2021

I thought we decided to pass the broadcast data as a reference. Did we change that?

DIALIN-DEN-8251-1 14 May 2021

Change to return type to None and remove not needed return 0 to keep consistency with other functions in this file.

DIALIN-DEN-7820-1 28 May 2021

RESOLVED

DIALIN-DEN-8514-1 28 May 2021

Missing .value

HD-DEN-8103-1 29 May 2021

Removed.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11750-1 03 Mar 2022

I will address them in DEN-12224.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 18 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 04 Nov 2021

Does 2400 RPM get us 2400 mL/min drain rate? It's the rate that we want to be 2400.

DIALIN-DEN-7860-1 19 May 2021

Are you referring to comment section below? There I state @param ms: integer (in ms) etc. If you are referring to something else, please provide an example of what you are expecting to see as I do not understand the comment.

DG-DEN-9480-1 04 Nov 2021

Make a private definitions section above private data and move this there.

DG-DEN-13598-2 26 Sep 2022

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1 06 Nov 2021

Added the TODO back.

DIALIN-DEN-7860-1 19 May 2021

Instead of

 cmd_air_bubbles_data_broadcast_interval_override(self, ms, reset=NO_RESET): 

you need

 cmd_air_bubbles_data_broadcast_interval_override(self, ms: int, reset: int = NO_RESET) -> int: 

It is necessary to have typing information in commands so the service app can call them correctly
Also, putting the typing information in the docstring is good, but it's better to have it in the function so that it can be dynamically interpreted when the code is inspected

DG-DEN-9480-1 06 Nov 2021

The drain flow rate does not matter in any of the disinfects. The faster the drain, the better.

HD-DEN-13903-1 23 Sep 2022

Need F. Magic numbers should be #define?

DG-DEN-9480-1 09 Nov 2021

In @details Inputs and Outputs, replace heatersVoltageMonitorTimeCounter with voltageMonitorTimeCounter.

DIALIN-DEN-7860-1 19 May 2021

I think older classes may not have get functions for everything, but Sarina and others prefer get functions to accessing properties directly so we're trying to create get functions for every collected data.

UI-DEN-10206-1 03 Nov 2021

Remove extra line.

UI-DEN-10599-1 03 Nov 2021

Remove extra line.

DG-DEN-9480-1 06 Nov 2021

The calibration of FMD has been added in DEN-9906 branch.

UI-DEN-8308-1 24 May 2021

Updated

UI-DEN-12121-1 03 Mar 2022

remove empty line.

UI-DEN-8308-1 24 May 2021

The copyright is missing

UI-DEN-8308-1 21 May 2021

The docstring is missing

UI-DEN-8308-1 24 May 2021

The copyright is missing

UI-DEN-8308-1 25 May 2021

The dg simulator needs to be used for dg responses here still

DG-DEN-8103-1 19 May 2021

Place TRUE as first argument.

DG-DEN-8103-1 19 May 2021

Should we move this enum to separate .h file?

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 04 Nov 2021

Should we keep the TODO for this?

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH

HD-DEN-9480-1 09 Nov 2021

Need to restore this code.

DIALIN-DEN-9480-1 09 Nov 2021

Should we have a NUM_OF_DG_EVENT_DATA_TYPES at end of enum?

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 28 Feb 2022

This (2000) is a minimum for a warning. Alarm if > 2200. Sensor should normally be below 2000 (so not a minimum really).
I think we still want a minimum. Not sure if 100 was correct before. Check with Systems.

DG-DEN-12121-1 04 Mar 2022

Add space between if and (.

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DIALIN-DEN-12121-1 09 Mar 2022

Updated doc string to format that methods follow. Note: none follow
@param (int): <description>
@return (int): <description>

They are:
@param: (int) <description>
@return: (int) <description>

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DIALIN-DEN-12121-1 04 Mar 2022

Please update the docstring here and on top.

HD-DEN-12121-1 06 Mar 2022

Align the comment.

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.