•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7605-2 06 May 2021

initBloodPrime() is called every time we transition to blood prime sub-mode.

UI-DEN-8085-1 06 May 2021

RESOLVED.

DIALIN-DEN-8251-1 11 May 2021

Done

DIALIN-DEN-7605-1 05 May 2021

Needs a return type

DIALIN-DEN-8251-1 11 May 2021

RESOLVED.

HD-DEN-7860-1 17 May 2021

Removed ADA/ADV bubble state test masks.

HD-DEN-7860-1 17 May 2021

Removed ADA/ADV bubble state test masks as there are no separate FPGA registers that output these variables.

HD-DEN-7860-1 17 May 2021

Addressed.

DIALIN-DEN-8251-1 14 May 2021

This function and the one below needs to match the new style.

DIALIN-DEN-7820-1 28 May 2021

RESOLVED

DG-DEN-7802-1 14 May 2021

Removed casting.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 11 May 2021

For blood leak sensor, we didn't want to go to normal state until it was zeroed and self-tested. For bubble detector, do we want to be stuck in init state until self-test is requested?
I think if we keep this state machine as is, we will want to request self-test in POST so that we can move on to normal state quickly. Then still request another self-test in each pre-treatment as we are now doing.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 11 May 2021

Recommend converting to a local variable rather than an array.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

We have not done this for any of the following features. After talking to Sean Nash, below is the TODO list.

  • HD Air Trap (TODO Sean Nash)
  • DG/HD Fluid Leak (DG TODO Sean Nash, HD TODO [~pmontazemi])
  • HD Blood Leak (TODO [~pmontazemi])
  • HD ADA/ADV Air Bubbles (TODO [~pmontazemi])
HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Corrected for both HD Blood Leak and HD Air Bubbles.

HD-DEN-7860-1 17 May 2021

Corrected comments for HD Fluid Leak, HD Blood Leak, and HD Air Bubbles

Sean Nash TODO Please correct header comment for DG Fluid Leak.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 17 May 2021

Addressed.

HD-DEN-7860-1 18 May 2021

payload is of type TEST_OVERRIDE_ARRAY_PAYLOAD_T (12 bytes). TEST_OVERRIDE_PAYLOAD_T (used below) is only 8 bytes. Change below to array version of test payload type.

HD-DEN-7860-1 18 May 2021

Addressed.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 18 May 2021

Addressed.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.