We're saving fill data to RTC RAM every 50ms?
RESOLVED in CODE WALKTHROUGH
Should we have a NUM_OF_HEAT_DISINFECT_UI_STATES at end of enum like others?
This is removed in my branch.
Remove blank line.
Shouldn't this be an else if in above if - else?
Should we have a NUM_OF_POST_STATES at the end of this enum like others?
Flow rate is F32 so change 0 to 0.0F.
This function is no longer needed.
If the pump is not on, the monitor checks the voltage to make sure it is reading 0. That code is a couple of lines above.
I uncommented it.
Done.
If separated like this, you are likely doing extra work (assigning list_of_events in above if/else and then potentially again in this if.
Do we need an else? What should we do if we're in a non-heating mode?
RESOLVED in CODE WALKTHROUGH.
Let's finish optimizing broadcasts.
@details Inputs and Outputs need update
I do not see isRMPNonZeroInClosedLoop used as outputs in this function.
What is the status of these commented out lines of code? Are we removing or keeping?
Why do I not see a call to this function in SystemComm.c?
Should we have a NUM_OF_CHEM_DISINFECT_UI_STATES at end of enum like others?
Can we move this file to common folder so that f/w team can make updates as needed when adding new messages?
Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?
Updated in the latest branch. The Link is attached.
Yes, you are right. I will use fwcommon code.
Rephrase: "Merge the two modes as they have much in common in this case."
Fixed.
Persistence spell error.
Done
I do not see this mode my local code base. It might have been git.
please move it in an appropriate folder(dg/adjustment)
RESOLVED
The one which has been used in the VDateTime is much cleaner:
if (_process.state() == QProcess::Running) { return; }
Please add the return type as int
reset:int=NO_RESET) -> int:
I removed it.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
