•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-9480-1 09 Nov 2021

It was not in my branch but I added it.

DIALIN-DEN-9480-1 10 Nov 2021

Done.

DIALIN-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-9480-1 05 Nov 2021

We want 2400 mL/min. Will this RPM speed result in desired flow rate?

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9480-1 09 Nov 2021

What is the status of this line of code? Are we removing it or keeping it?

DG-DEN-9480-1 10 Nov 2021

MSG id should be HD accel data

DIALIN-DEN-9480-1 09 Nov 2021

Should we add a NUM_OF_HD_SWITCHES to end of enum?

DG-DEN-7802-1 03 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7752-1 29 Apr 2021

please change this to eDG.

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7752-1 06 May 2021

RESOLVED

UI-DEN-8085-1 06 May 2021

RESOLVED

UI-DEN-8085-1 06 May 2021

RESOLVED

HD-DEN-8886-1 18 Aug 2021

Please add the PN and the manufacturer of the sensors.

DIALIN-DEN-7605-1 11 May 2021

RESOLVED

DIALIN-DEN-7605-1 05 May 2021

Needs a return type

UI-DEN-9626-1 21 Sep 2021

updated.

DIALIN-DEN-9906-1 06 Nov 2021

Dara Navaei I assume we should not be worried about the authors and Bamboo copyright is enabled on Dialin, right?

UI-DEN-9626-1 22 Sep 2021

Remove blank line.

UI-DEN-8308-1 11 May 2021

There is no unit for the items in these indexes for example Device ID doesn't have a unit and then it will leave blank for that one.

UI-DEN-9626-1 20 Sep 2021

it is (formal) instead of it's (informal)

HD-DEN-7860-1 13 May 2021

Are we adding an alarm here later?

HD-DEN-7605-2 07 May 2021

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again.
Suggest creating a BOOL variable to have all three conditions or with each other and call isPersistentAlarmTriggered() only once.

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-10424-1 11 Oct 2021

Where was this code moved to or was it dead code laying around?

DG-DEN-9906-1 25 Oct 2021

Added override reset functions

DG-DEN-9906-1 25 Oct 2021

Fixed

DG-DEN-9906-1 25 Oct 2021

Fixed

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

DG-DEN-11928-1 04 Mar 2022

Replaced COND_SENSOR_CPI_MAX_VALUE with COND_SENSOR_CPI_WARNING_HIGH
and removed #define COND_SENSOR_CPI_MAX_VALUE

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-10206-1 08 Nov 2021

RESOLVED.

UI-DEN-10206-1 04 Nov 2021

Updated in the latest branch. The Link is attached.

DG-DEN-12121-1 06 Mar 2022

Add a space.

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 06 Mar 2022

I noticed you are using a U32 as a boolean without typecasting. I know a boolean is an unsigned integer behind the scenes but to be specific we should explicitly typecast.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 31 Mar 2022

RESOLVED in WALKTHROUGH.

DG-DEN-12931-1 03 Aug 2022

Done.

DIALIN-DEN-9480-1 09 Nov 2021

Should we have a NUM_OF_DG_EVENTS at end of enum?

DG-DEN-9480-1 09 Nov 2021

This part is under development and I have been working on the happy path of the heaters. I added a build switch for now.

DG-DEN-9480-1 09 Nov 2021

If we are in a non-heating mode, the heaters do not need to be on and we should not be in this state.