•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-8085-1 29 Apr 2021

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

DIALIN-DEN-7605-1 11 May 2021

RESOLVED

DG-DEN-7802-1 18 Aug 2021

Renamed to match new alarm ID.

HD-DEN-8886-1 19 Aug 2021

Done.

HD-DEN-8886-1 18 Aug 2021

Should we include "TestSupport.h" for function declaration?

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 16 Aug 2021

Please add why you are using this include.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8886-1 19 Aug 2021

RESOLVED.

UI-DEN-9626-1 21 Sep 2021

updated.

UI-DEN-9626-1 23 Sep 2021

RESOLVED.

UI-DEN-9626-1 22 Sep 2021

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use).
So this comment appears to be inconsistent with the header file.

UI-DEN-9626-1 21 Sep 2021

RESOLVED.

DIALIN-DEN-9626-1 21 Sep 2021

Why some commands return boolean and some none? And this function always returns TRUE so what is the point?
Also, when a function returns something, I thought we decided to show that in the declaration ( e.g. foo() -> int: )

UI-DEN-9626-1 20 Sep 2021

We either start with Capital Letter everywhere or we don't.

UI-DEN-9626-1 24 Sep 2021

RESOLVED.

UI-DEN-9626-1 20 Sep 2021

Remove extra spaces after vData.

DG-DEN-9906-1 21 Oct 2021

Update this function header - not RO pump.

HD-DEN-9906-1 27 Oct 2021

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-9906-1 21 Oct 2021

I think this is from old flow sensor. Get new value from Dara.

DG-DEN-9906-1 21 Oct 2021

Update return comment.

HD-DEN-10153-1 26 Oct 2021

If no params, put void.

HD-DEN-10153-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-9906-1 28 Oct 2021

Move up for alphabetical order.
Also, need to add an import for this class at top of module.

DG-DEN-9906-1 21 Oct 2021

Need "Reset" versions of these override functions too.
Also need to add override command message IDs for publish interval and flow override commands + handling of these messages so that these override functions will be called.

DG-DEN-9906-1 21 Oct 2021

For consistency, we put init functions first.

DIALIN-DEN-9906-1 28 Oct 2021

Fixed

DIALIN-DEN-9906-1 28 Oct 2021

I think you need to change "flow" to "flow[0]" here.

DIALIN-DEN-9906-1 28 Oct 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

Function needs header.

UI-DEN-10206-1 01 Nov 2021

This function header is autogenerated by Doxygen getting the comments from the macros.
Please look into the updated DeviceGlobals.h

UI-DEN-10206-1 01 Nov 2021

removed

UI-DEN-10206-1 01 Nov 2021

No details?

DG-DEN-9480-1 04 Nov 2021

Can the two datas be memcpy'd as EVENT_DATA_Ts instead of U32 and EVENT_DATAS_T separately?

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 03 May 2021

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 30 Mar 2022

Moved publishBadFillSubstates(); to the end of execGenIdle function

HD-DEN-7605-2 03 May 2021

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

HD-DEN-8886-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8085-1 04 May 2021

Done

UI-DEN-15279-1 05 Jun 2023

filed -> "failed" ?
hte -> the

UI-DEN-7752-1 29 Apr 2021

please move it in an appropriate folder(hd/adjustment)