•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-8085-1 29 Apr 2021

Please don't use "%0" as we discussed.

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 13 Aug 2021

Done.

HD-DEN-8886-1 19 Aug 2021

Done.

HD-DEN-8886-1 19 Aug 2021

Usually. But this function is called by AlarmMgmt (not really a h/w driver) so I kept the conversion at FPGA level to keep it low level.

DIALIN-DEN-7605-1 05 May 2021

Needs a return type

HD-DEN-8886-1 19 Aug 2021

Added.

HD-DEN-7860-1 11 May 2021

I think this makes sense. We've done the same in other monitors/controllers like valves where there are several similar components handled in same driver.

HD-DEN-7860-1 11 May 2021

Why should we need a separate mask for bubble test state? I thought the normal input status mask should be sufficient to see the faked air bubble.

HD-DEN-7860-1 11 May 2021

Recommend converting to a local variable rather than an array.

HD-DEN-7860-1 11 May 2021

These should be bit 2 (0x04) and bit 3 (0x08).

HD-DEN-7860-1 11 May 2021

Incorrect enum.

HD-DEN-8886-1 19 Aug 2021

Fixed.

HD-DEN-8886-1 19 Aug 2021

Fixed.

DG-DEN-7802-1 19 Aug 2021

Done.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 19 Aug 2021

I would prefer we return a TRUE or FALSE explicitly (like function below).

DG-DEN-7802-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 19 Aug 2021

So we are not monitoring these, but we are publishing them?

DIALIN-DEN-8886-1 19 Aug 2021

RESOLVED.

DG-DEN-7802-1 27 Aug 2021

Nice catch. Fixed.

HD-DEN-7802-1 27 Aug 2021

Removed dialysate temp check for treatment end sub-mode.

DG-DEN-7802-1 31 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7802-1 27 Aug 2021

I think we do want to check dialysate temperature during treatment, but maybe not in every sub-mode. For example, I think in treatment end sub-mode we have the dialyzer bypassed (no longer performing dialysis) so there is no need to worry about the dialysate temp anymore. That is the only exception I can think of at the moment.

UI-DEN-9626-1 20 Sep 2021

QApplication is misspelled

UI-DEN-9626-1 22 Sep 2021

Updated the comments to clarify.
In ' ..., and them,...' it meant logical AND &&.
And added a lot more comments.

UI-DEN-9626-1 22 Sep 2021

Thanks for the comment.
I removed those two and updated the comments as well.

UI-DEN-9626-1 23 Sep 2021

RESOLVED.

UI-DEN-9626-1 20 Sep 2021

We either start with Capital letter everywhere or we don't.

UI-DEN-10424-1 11 Oct 2021

RESOLVED.

DG-DEN-9906-1 25 Oct 2021

Fixed.

HD-DEN-10153-1 26 Oct 2021

Fixed

HD-DEN-9906-1 26 Oct 2021

Fixed.

HD-DEN-9906-1 27 Oct 2021

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the two values that you are toggling between.

HD-DEN-9906-1 27 Oct 2021

RESOLVED IN CODE WALKTHROUGH

DG-DEN-9906-1 21 Oct 2021

I think we need to lower this minimum. We will be running dialysate at rates as low as 100 mL/min so we probably need to be able to see rates as low as 0.05 L/min.

HD-DEN-10153-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-9906-1 28 Oct 2021

RESOLVED.

DIALIN-DEN-9906-1 28 Oct 2021

You don't have a property called sensor to publish. Change 'sensor' to 'flow_rate'.

DIALIN-DEN-9906-1 28 Oct 2021

Add brief for function description. Add logger param.

HD-DEN-9906-1 01 Nov 2021

Added file header.

DG-DEN-7802-1 14 May 2021

Should maybe cast here though.

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14253-1 02 Dec 2022

Done.

UI-DEN-9411-1 13 Aug 2021

RESOLVED.

DIALIN-DEN-8886-1 19 Aug 2021

Add space between ":" and "=" to match PEP8 standard.
Add "-> bool:" at the end to indicate the return type.

HD-DEN-7605-2 03 May 2021

Fixed.