Comment Search

Defect Metrics

Statistics on the results
No defects in results

Search Criteria

Search for comments

Search Criteria

Project
Comment content
Review PermaId
After
Before
Comment Author
Search Type
Search Type:
Review State
Review State:
Metrics:
Metric Ranking
Metric Classification
Submit
  •  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-10153-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.
HD-DEN-10153-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.
DIALIN-DEN-9906-1 28 Oct 2021

Fixed
DIALIN-DEN-9906-1 28 Oct 2021

RESOLVED.
DG-DEN-9906-1 27 Oct 2021

These persistent alarms (the enums) are for the FMP. I think we should add new enums for the FMD.
DIALIN-DEN-9906-1 28 Oct 2021

This class does not appear to use DialinEnum. Remove it.
DIALIN-DEN-9906-1 28 Oct 2021

RESOLVED.
UI-DEN-10206-1 01 Nov 2021

Function needs header.
UI-DEN-10206-1 01 Nov 2021

RESOLVED.
UI-DEN-10206-1 01 Nov 2021

Magic numbers.
UI-DEN-10206-1 01 Nov 2021

RESOLVED.
UI-DEN-10206-1 01 Nov 2021

Should we have a TODO or FIXME here?
UI-DEN-10206-1 01 Nov 2021

This function header is autogenerated by Doxygen getting the comments from the macros.
Please look into the updated DeviceGlobals.h
UI-DEN-10206-1 01 Nov 2021

This function header is autogenerated by Doxygen getting the comments from the macros.
Please look into the updated DeviceGlobals.h
UI-DEN-10206-1 01 Nov 2021

This function header is autogenerated by Doxygen getting the comments from the macros.
UI-DEN-10206-1 01 Nov 2021

This function header is autogenerated by Doxygen getting the comments from the macros.
Please look into the updated DeviceGlobals.h
UI-DEN-10206-1 01 Nov 2021

Is outBuff still needed? Delete?
UI-DEN-10206-1 01 Nov 2021

RESOLVED.
UI-DEN-10206-1 01 Nov 2021

RESOLVED.
UI-DEN-10206-1 01 Nov 2021

Function needs header.
DIALIN-DEN-9906-1 28 Oct 2021

Does init function return anything?
DG-DEN-11750-1 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.
HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.
DIALIN-DEN-8251-1 05 May 2021

Mismatch filename.
HD-DEN-11750-2 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.
HD-DEN-8886-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.
HD-DEN-7860-1 11 May 2021

I think it's worth checking that the self-test mode was entered as expected.
UI-DEN-7752-1 06 May 2021

Please change to "Event".
Datum: is a message that comes regularly in a certain period.
Event: is a message that comes on a request only and can happen anytime.
Please update the SDDUI 286.
DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.
DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.
HD-DEN-9906-1 26 Oct 2021

add last else
else
{

}
DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.
DG-DEN-7802-1 29 Apr 2021

Add blank line between declarations and code.
UI-DEN-9411-1 13 Aug 2021

RESOLVED.
DIALIN-DEN-8055-1 04 May 2021

RESOLVED.
HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.
HD-DEN-7605-2 07 May 2021

Same as comment from DialinFlow.c
HD-DEN-8886-1 18 Aug 2021

File name mismatch.
HD-DEN-8886-1 18 Aug 2021

Missing doxygen comments.
UI-DEN-7752-1 04 May 2021

This is used in INTERPRET_RECVD_MT_MESSAGE in MessageInterpreter.cpp.
It is overridden so a broadcast is sent out instead of a direct message to the HD.
DG-DEN-7802-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.
DIALIN-DEN-7605-1 06 May 2021

Fixed.
HD-DEN-7802-1 31 Aug 2021

RESOLVED in CODE WALKTHROUGH.
UI-DEN-7752-1 06 May 2021

RESOLVED.
DIALIN-DEN-9906-1 28 Oct 2021

RESOLVED.
UI-DEN-7752-1 06 May 2021

RESOLVED
UI-DEN-7752-1 29 Apr 2021

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used.
So it would be better to have key or value as QStringList properties and change these properties to just values.
UI-DEN-8085-1 29 Apr 2021

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).