•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-10206-1 01 Nov 2021

Updated

UI-DEN-10206-1 01 Nov 2021

Updated

UI-DEN-10206-1 01 Nov 2021

Function needs header.

UI-DEN-10206-1 01 Nov 2021

This function header is autogenerated by Doxygen getting the comments from the macros.
Please look into the updated DeviceGlobals.h

UI-DEN-10206-1 01 Nov 2021

updated

UI-DEN-10206-1 01 Nov 2021

Function needs header.

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

Function needs header.

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

updated

UI-DEN-12121-1 02 Mar 2022

Fixed. Thanks!

HD-DEN-8886-1 13 Aug 2021

Variable is in the isAirTrapControlling() function.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

reverted the clear

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 03 May 2021

I agree, but sometimes feel it helps readability.

HD-DEN-7605-2 03 May 2021

No more self-test (and associated self-test state machine) for heparin pump?

HD-DEN-7605-2 03 May 2021

Add blank line between declaration and code.

UI-DEN-12121-1 02 Mar 2022

Fixed. Thanks!

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7752-1 04 May 2021

Done

UI-DEN-7752-1 04 May 2021

The m is now removed and replaced with underscores to indicate that they are private.

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11750-2 02 Mar 2022

No, this should be removed. If this is in an else, in a release build it is not going to compile sine the if will be ignored.

DIALIN-DEN-8055-1 05 May 2021

Done

UI-DEN-9411-1 13 Aug 2021

RESOLVED.

UI-DEN-8085-1 29 Apr 2021

It prevents updates to alarmVolume by the HD broadcast while we're editing the alarm volume.
Otherwise, alarmVolume could be incorrectly updated by an HD broadcast of a set alarm volume that the user decided to cancel.

UI-DEN-9411-1 13 Aug 2021

RESOLVED.

DG-DEN-11750-1 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.

DG-DEN-12931-1 03 Aug 2022

Done

HD-DEN-8886-1 19 Aug 2021

Common.h includes TestSupport.h.

DG-DEN-8886-1 13 Aug 2021

Missing return for non-void function.

DIALIN-DEN-7605-1 06 May 2021

Done.

UI-DEN-7752-1 06 May 2021

RESOLVED

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 18 Aug 2021

Please mention the usage of this include.

DIALIN-DEN-8251-1 11 May 2021

Done

DIALIN-DEN-7605-1 05 May 2021

Typing information missing for parameters
Return type is missing

HD-DEN-7605-2 11 May 2021

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 19 Aug 2021

Done.

HD-DEN-7860-1 12 May 2021

We plan on doing self-test as part of priming, so we confirm the bubble detector reads air on a new cartridge, then we check that we read fluid when we have completed priming. I need to add these checks. The air bubble detector alarm, however, should only be active during treatment (includes blood prime and rinseback), and outside of that we just monitor the detectors but never alarm. Therefore, we do not need to do the self-test in POST and it is fine to keep handleInitBubbleState(...) as is.

Note: No code change to handleInitBubbleState(...).

HD-DEN-7860-1 13 May 2021

It looks like you have not added these functions to SystemComm.c. They need to be added there otherwise the commands will not be handled.

HD-DEN-7860-1 11 May 2021

Code below looks like this message is expected to have a payload of type OVERRIDE_PUMP_SET_PT_PAYLOAD_T. Not sure why a bubble test request would have a pump type payload, maybe it had what you needed (an index). But this structure will have a length larger than 0. Should be "if ( sizeof( OVERRIDE_PUMP_SET_PT_PAYLOAD_T ) == message->hdr.payloadLen ).

DIALIN-DEN-8886-1 19 Aug 2021

Done.

DIALIN-DEN-8886-1 19 Aug 2021

Done.

DIALIN-DEN-9633-1 27 Aug 2021

Copy paste error. Fixed.

UI-DEN-9411-1 12 Aug 2021

1. Replace couldn't with could not;
2. We decided to explore other means to obtain the true RTC clock rather than the MPU's Linux clock. What were the results of that exploration and where is it reflected in this code?

DG-DEN-7802-1 27 Aug 2021

The max part of these do not look right (backward).