RESOLVED
Done.
Done
Recommend converting to a local variable rather than an array.
Maybe cast the status params as U32 as well so there won't be an issue within the broadcast function (see my comment there for context).
The brief does not match with what the function does.
Was it not decided to just get the FPGA counts and then do the conversion into the driver that calls the FPGA function?
RESOLVED in CODE WALKTHROUGH.
Add space after "=" for "=NO_RESET".
Does this mean commenting out these 2 lines fixed a bug? If so, why not just delete them?
Why is this function duplicated?
Temporary? Maybe add a // TODO or is // DEBUG something you'll know to search for later?
RESOLVED.
Fixed
Blank line removed
I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.
Fixed.
RESOLVED IN CODE WALKTHROUGH.
per MISRA, need the else statement at the end of if { }- else if { } - else if { }- else { }
RESOLVED IN CODE WALKTHROUGH
Add file header
Wrong field name.
Don't need this function - variable is local to this module.
Put float in parenthesis.
This debug logging line is missing in flow override function above.
I think new modules should start copyright at current year - change 2019 to 2021.
Function needs header.
Why cast here?
What declaration?
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
