Done.
Only two places call this function. Should we inline and remove this function?
Revert the deleted comment.
RESOLVED in CODE WALKTHROUGH.
RESOLVED in WALKTHROUGH.
This struct needs doxygen comment on individual member.
Only reverse when using == operator
Commenting out these variables will cause out of sync issues between what is currently in DG develop. Current conductivity data struct in DG develop: /// Conductivity data struct. F32 roRejectionRatio; ///< RO rejection ratio F32 cpi; ///< CPi conductivity sensor value F32 cpo; ///< CPo conductivity sensor value F32 cd1; ///< CD1 conductivity sensor value F32 cd2; ///< CD2 conductivity sensor value F32 cpiRaw; ///< CPi raw conductivity sensor value (without 2% temperature compensated) F32 cpoRaw; ///< CPo raw conductivity sensor value (without 2% temperature compensated) F32 cd1Raw; ///< CD1 raw conductivity sensor value (without 2% temperature compensated) F32 cd2Raw; ///< CD2 raw conductivity sensor value (without 2% temperature compensated) U32 cpiSensorStatus; ///< CPi conductivity sensor status U32 cpoSensorStatus; ///< CPo conductivity sensor status U32 cd1SensorStatus; ///< CD1 conductivity sensor status U32 cd2SensorStatus; ///< CD2 conductivity sensor status CONDUCTIVITY_DATA_T; please be careful when we are merging this into staging
RESOLVED.
We typically put #define like this in the source file. Is there a reason why this one is in the header file specifically?
RESOLVED for now.
Leave as is per conversation w Sean. Reported by HD, but actually a DG generated problem.
Updated
Maybe change param name to final (i.e. final or start).
Are we sticking with this threshold?
Use our boolean #define (FALSE) instead of built-in (false).
At the moment I added that switch I assumed it should only be used for V&V and SysV testing.
All systems will be setup for Pacific time zone?
Why did this change? I think it's needed for doxygen.
was MSG_ID_HD_ACCELEROMETER_DATA supposed to be removed as well?
Add comments like others.
Fix alignment.
Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.
Add blank line between declarations and code.
Not really but since I'm not done with new ones, I would still keep them for a while.
I reviewed these - fixed any differences due to merge. There is one more threshold change pending that I'm aware of. I will make in next branch.
I mean, all others appear to be in the following order: 1) number of params and 2) size of params. So to be consistent, shouldn't this be 1 * 15 (1 param, 15 bytes)?
According to message list, there should be 2 parameters in the blood leak data message: 1) status and 2) state.
fixed thanks!
It has been removed.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
