Comment Search

Defect Metrics

Statistics on the results
No defects in results

Search Criteria

Search for comments

Search Criteria

Project
Comment content
Review PermaId
After
Before
Comment Author
Search Type
Search Type:
Review State
Review State:
Metrics:
Metric Ranking
Metric Classification
Submit
  •  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11928-1 31 Mar 2022

RESOLVED in WALKTHROUGH.
DIALIN-DEN-11928-1 31 Mar 2022

RESOLVED.
DIALIN-DEN-11928-1 28 Mar 2022

Please change the struct.unpack parameters from big endian to little endian. Reference below:

https://docs.python.org/3/library/struct.html#format-characters
DG-DEN-12224-7 30 Mar 2022

Remove blank line.
HD-DEN-12224-16 24 May 2022

RESOLVED in CODE WALKTHROUGH.
DG-DEN-12224-7 24 May 2022

Done.
DIALIN-DEN-12224-1 20 Jun 2022

Will be addressed in in DIAL-171.
HD-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.
HD-DEN-12847-1 30 Jun 2022

Use FALSE, not false.
HD-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.
DIALIN-DEN-12716-1 06 Jul 2022

RESOLVED.
UI-DEN-12716-2 06 Jul 2022

RESOLVED.
UI-DEN-12716-2 06 Jul 2022

RESOLVED.
DG-DEN-12931-1 23 Jul 2022

Keep this blank line.
HD-DEN-12931-2 18 Jul 2022

Is this supposed to have been removed.
HD-DEN-12931-2 12 Jul 2022

indent of cases looks too small.
HD-DEN-12931-2 21 Jul 2022

No. Code removed.
DG-DEN-12931-1 23 Jul 2022

Add blank line between declarations and code.
DG-DEN-12974-1 28 Jun 2022

Why is this commented out?
DG-DEN-12931-1 22 Jul 2022

This assignment should be done above at declaration. Move calStatus declaration above result.
DG-DEN-12931-1 22 Jul 2022

Do either of these 2 if statements need an else?
HD-DEN-12931-2 07 Jul 2022

Do we want to keep this debug & sprintf?
HD-DEN-12931-2 21 Jul 2022

Can we remove this now?
HD-DEN-12931-2 18 Jul 2022

Need #define for minimum vRef
HD-DEN-12931-2 18 Jul 2022

Is the data being published elsewhere?
DG-DEN-12974-1 28 Jun 2022

Why is this alarm commented out?
HD-DEN-7395-1 15 Apr 2021

Recommend adding _MS to the end to indicate the metric in milliseconds.
UI-DEN-9411-1 12 Aug 2021

RESOLVED.
DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.
HD-DEN-11750-2 02 Mar 2022

Done.
DIALIN-DEN-7395-1 19 Apr 2021

RESOLVED.
SRVC-DEN-7335-1 21 Apr 2021

RESOLVED.
DG-DEN-11750-1 02 Mar 2022

Done.
DG-DEN-7802-1 12 Aug 2021

AlarmMgmt checks for HD communication (in SystemComm) before broadcast trigger message (prevent NACK issue).
UI-DEN-7820-1 22 Apr 2021

RESOLVED.
HD-DEN-13598-2 26 Sep 2022

RESOLVED in CODE WALKTHROUGH
HD-DEN-7347-1 25 Apr 2021

The function has been removed.
HD-DEN-7347-1 25 Apr 2021

Inputs and outputs are missing.
HD-DEN-13598-2 26 Sep 2022

RESOLVED in CODE WALKTHROUGH
DG-DEN-13598-2 26 Sep 2022

RESOLVED in CODE WALKTHROUGH
DG-DEN-13598-2 23 Sep 2022

Update function header.
DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.
DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.
DG-DEN-11928-1 03 Mar 2022

I am not clear on this question, do you want to use the load cell to weight samples based on the concentrate pump rate?
DG-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH
DG-DEN-11928-1 30 Mar 2022

Doesn't next state need acid zeroed here?
DG-DEN-11928-1 30 Mar 2022

I don't see this getting initialized anywhere. Should be initialized in init function. Consider stagger when initializing it.
DG-DEN-11928-1 30 Mar 2022

delete one of these blank lines.
DIALIN-DEN-12224-1 20 Jun 2022

RESOLVED.
DIALIN-DEN-12224-1 01 Apr 2022

As much as I dont like this (Values should be left numerical. Let the API user convert it to something easier to read if they want), please add the same value check for wet_self_test_state.