RESOLVED in CODE WALKTHROUGH.
Done.
Will be addressed in in DIAL-171.
Use FALSE, not false.
RESOLVED.
Keep this blank line.
Is this supposed to have been removed.
indent of cases looks too small.
No. Code removed.
Add blank line between declarations and code.
Why is this commented out?
This assignment should be done above at declaration. Move calStatus declaration above result.
Do either of these 2 if statements need an else?
Do we want to keep this debug & sprintf?
Can we remove this now?
Need #define for minimum vRef
Is the data being published elsewhere?
Why is this alarm commented out?
Recommend adding _MS to the end to indicate the metric in milliseconds.
AlarmMgmt checks for HD communication (in SystemComm) before broadcast trigger message (prevent NACK issue).
RESOLVED in CODE WALKTHROUGH
The function has been removed.
Inputs and outputs are missing.
Update function header.
I am not clear on this question, do you want to use the load cell to weight samples based on the concentrate pump rate?
RESOLVED IN CODE WALKTHROUGH
Doesn't next state need acid zeroed here?
I don't see this getting initialized anywhere. Should be initialized in init function. Consider stagger when initializing it.
delete one of these blank lines.
As much as I dont like this (Values should be left numerical. Let the API user convert it to something easier to read if they want), please add the same value check for wet_self_test_state.
Please change the byte order for the .unpack
This will be addressed in DEN-12931.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
