•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-BUG-S63-1 20 Jan 2022

For this kind of logging, I think we should use the logger class.

UI-DEN-12182-2 02 Mar 2022

RESOLVED.

DG-DEN-11928-1 03 Mar 2022

Because the RO pump target flow rate is in liter per minute
I updated RO_PUMP_400_ML_PER_MIN from 0.4 to 400.0
RO_PUMP_800_ML_PER_MIN from 0.8 to 800.0
Added #define MILLILITERS_PER_LITER 1000.0 and use this value in
setROPumpTargetFlowRateLPM( RO_PUMP_800_ML_PER_MIN / MILLILITERS_PER_LITER, TARGET_RO_PRESSURE_PSI );

DIALIN-UI-S63-1 15 Feb 2022

RESOLVED.

HD-DEN-11250-1 31 Jan 2022

Remove blank line. Cannot make changes outside of user code blocks.

DG-DEN-11928-1 01 Mar 2022

According to SRSDG 216, While in Fill-Dialysate Production state, the DG Software shall transition to Fill-Deliver Dialysate state when the dialysate temperature is in target set temperature ± 2° C and water quality is good (conductivity, pressure, temperature) for at least 3 s ± 100 ms.

HD-DEN-11750-2 03 Mar 2022

Done.

HD-DEN-11750-2 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.

DG-DEN-11750-1 02 Mar 2022

Who's right?

HD-DEN-11750-2 02 Mar 2022

Remove blank line. And what is new remove field for?

UI-DEN-9411-1 12 Aug 2021

RESOLVED.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUG

RO-LDT-1242-1 03 Sep 2025

removed comment.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-9411-1 12 Aug 2021

RESOLVED.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-9411-1 12 Aug 2021

Added.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 19 Apr 2021

I uncommented it.

DIALIN-DEN-7395-1 19 Apr 2021

Addressed.

UI-DEN-9411-1 12 Aug 2021

Updated.

DIALIN-DEN-7395-1 19 Apr 2021

RESOLVED.

DIALIN-DEN-7792-1 21 Apr 2021

RESOLVED.

DG-DEN-7802-1 12 Aug 2021

Removed. This windowed count is removed in branch DEN-8886. There is no definition for it anymore.

DG-DEN-7568-1 22 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11750-1 02 Mar 2022

I brought the BOOL back.

DG-DEN-7568-1 23 Apr 2021

This code is very similar to heat disinfect, so I decided to keep this function.

HD-DEN-13903-2 23 Sep 2022

Need separate config?

DG-DEN-7568-1 23 Apr 2021

RESOLVED in

DIALIN-DEN-11928-1 31 Mar 2022

Done.

UI-DEN-12121-1 02 Mar 2022

Fixed. Thanks!

UI-DEN-12121-1 02 Mar 2022

Fixed. Thanks!

DG-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-11750-2 02 Mar 2022

Done.

DG-DEN-11750-1 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.

HD-DEN-13598-2 27 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11750-1 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.

HD-DEN-11750-2 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.

HD-DEN-13903-2 23 Sep 2022

Update function header. primeFirstPurgePass

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11750-2 02 Mar 2022

These appear to be Dialin message functions. They should be down in the Dialin section below the TEST SUPPORT FUNCTIONS banner.

HD-DEN-11750-2 02 Mar 2022

Seems we are not consistent about using #ifndef RELEASE. We have it here, but not in the if above on line 400.

UI-DEN-12121-1 02 Mar 2022

Sean Nash,
How the change to the TreatmentState message will affect the Application?
This newly added parameter seems redundant to me.

The change is the "Dialysis State" addition.

10 - (U32) Dialysis state
Unknown macro: { 0=start, 1=UF, 2=saline bolus }

0x0F00 15 0x040 4 Hz N HD All Treatment State sub-mode (U32-enum) (U32) UF state (U32) saline bolus state (U32) Hep state (U32) Rinseback state (U32) Recirc state 7 - (U32) Bld Prime state 8 - (U32) Tx End state 9 - (U32) Stop state 10 - (U32) Dialysis state
HD-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 31 Mar 2022

RESOLVED in WALKTHROUGH.

DIALIN-DEN-11928-1 31 Mar 2022

RESOLVED.

DIALIN-DEN-11928-1 28 Mar 2022

Please change the struct.unpack parameters from big endian to little endian. Reference below:

https://docs.python.org/3/library/struct.html#format-characters

DG-DEN-12224-7 30 Mar 2022

Remove blank line.